Skip to content
Browse files

Take about 1.5 sec off z_steinert_signal_integrity.pm.

Most of these fixes are merely reducing timeouts once an expected
condition is met.  The long wait-for-failure timeout isn't as
important once a test has passed, but turning off the timer entirely
isn't good either.  There could be spurious events that we don't want,
and waiting a little extra time gives us some confidence they aren't
happening.
  • Loading branch information...
1 parent d7fa569 commit 50ce8766b931274fcc11ee8da6f1353418f9fb91 @rcaputo committed Jul 12, 2014
View
1 lib/POE/Test/Loops/k_sig_child.pm
@@ -154,7 +154,6 @@ POE::Session->create(
}
$kernel->yield( 'forking_time_is_up' );
- note("Waiting 1 second for child processes to settle.");
},
_stop => sub {
View
1 lib/POE/Test/Loops/k_signals.pm
@@ -103,7 +103,6 @@ POE::Session->create(
"forked $heap->{forked} processes (out of $fork_count)"
);
-
# NOTE: This is bad form. We're going to block here until all
# children check in, or die trying.
View
3 lib/POE/Test/Loops/z_steinert_signal_integrity.pm
@@ -58,6 +58,9 @@ sub handle_signal {
($_[ARG1] == 99),
"signal parameters: ('$_[ARG0]' eq 'MOO', $_[ARG1] == 99)"
);
+
+ # Wait just a little bit, in case of spurious signal.
+ POE::Kernel->delay( timed_out => 0.250 );
}
sub timed_out {

0 comments on commit 50ce876

Please sign in to comment.
Something went wrong with that request. Please try again.