Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

rename unidirectional -> oneway; bidirectional -> twoway

  • Loading branch information...
commit 76f16646e83e02fc12fd70a7f54411307226185e 1 parent 4afd144
@rcaputo authored
View
4 MANIFEST
@@ -21,8 +21,8 @@ POE/Filter/Stream.pm
POE/Kernel.pm
POE/NFA.pm
POE/Object.pm
-POE/Pipe/Bidirectional.pm
-POE/Pipe/Unidirectional.pm
+POE/Pipe/OneWay.pm
+POE/Pipe/TwoWay.pm
POE/Preprocessor.pm
POE/Repository/Array.pm
POE/Runtime.pm
View
10 lib/POE/Pipe/Unidirectional.pm → lib/POE/Pipe/OneWay.pm
@@ -1,9 +1,9 @@
# $Id$
-# Portable unidirectional pipe creation, trying as many different
-# methods as we can.
+# Portable one-way pipe creation, trying as many different methods as
+# we can.
-package POE::Pipe::Unidirectional;
+package POE::Pipe::OneWay;
use strict;
use Symbol qw(gensym);
@@ -70,7 +70,7 @@ sub new {
warn"using a UNIX domain socketpair: ar($a_read) bw($b_write)\n";
};
- # It's unidirectional, so shut down the unused directions.
+ # It's one-way, so shut down the unused directions.
shutdown($a_read, 1);
shutdown($b_write, 0);
@@ -126,7 +126,7 @@ sub new {
# Try sockets more often.
$can_run_socket = 1;
- # It's unidirectional, so shut down the unused directions.
+ # It's one-way, so shut down the unused directions.
shutdown($a_read, 1);
shutdown($b_write, 0);
View
8 lib/POE/Pipe/Bidirectional.pm → lib/POE/Pipe/TwoWay.pm
@@ -1,9 +1,9 @@
# $Id$
-# Portable bidirectional pipe creation, trying as many different
-# methods as we can.
+# Portable two-way pipe creation, trying as many different methods as
+# we can.
-package POE::Pipe::Bidirectional;
+package POE::Pipe::TwoWay;
use strict;
use Symbol qw(gensym);
@@ -75,7 +75,7 @@ sub new {
warn "ar($a_read) aw($a_write) br($b_read) bw($b_write)\n";
};
- # It's bidirectional, so each reader is also a writer.
+ # It's two-way, so each reader is also a writer.
$a_write = $a_read;
$b_write = $b_read;
View
8 lib/POE/Wheel/Run.pm
@@ -6,7 +6,7 @@ package POE::Wheel::Run;
use strict;
use Carp;
-use POE qw(Wheel Pipe::Unidirectional Driver::SysRW);
+use POE qw(Wheel Pipe::OneWay Driver::SysRW);
# Offsets into $self.
sub UNIQUE_ID () { 0 }
@@ -90,15 +90,15 @@ sub new {
# Make the pipes. We make more pipes than strictly necessary in
# case someone wants to turn some onn later.
- my ($stdin_read, $stdin_write) = POE::Pipe::Unidirectional->new();
+ my ($stdin_read, $stdin_write) = POE::Pipe::OneWay->new();
croak "could not make stdin pipes: $!"
unless defined $stdin_read and defined $stdin_write;
- my ($stdout_read, $stdout_write) = POE::Pipe::Unidirectional->new();
+ my ($stdout_read, $stdout_write) = POE::Pipe::OneWay->new();
croak "could not make stdout pipes: $!"
unless defined $stdout_read and defined $stdout_write;
- my ($stderr_read, $stderr_write) = POE::Pipe::Unidirectional->new();
+ my ($stderr_read, $stderr_write) = POE::Pipe::OneWay->new();
croak "could not make stderr pipes: $!"
unless defined $stderr_read and defined $stderr_write;
View
4 tests/04_selects.t
@@ -12,7 +12,7 @@ use TestSetup;
# Turn on all asserts.
#sub POE::Kernel::TRACE_DEFAULT () { 1 }
sub POE::Kernel::ASSERT_DEFAULT () { 1 }
-use POE qw(Pipe::Bidirectional);
+use POE qw(Pipe::TwoWay);
### Test parameters.
@@ -40,7 +40,7 @@ sub master_start {
$test_index *= 2;
my ($master_read, $master_write, $slave_read, $slave_write) =
- POE::Pipe::Bidirectional->new();
+ POE::Pipe::TwoWay->new();
unless (defined $master_read) {
$test_results[$test_index] = $test_results[$test_index + 1] = undef;
View
4 tests/06_tk.t
@@ -42,7 +42,7 @@ warn( "\n",
# Turn on all asserts.
sub POE::Kernel::ASSERT_DEFAULT () { 1 }
-use POE qw(Wheel::ReadWrite Filter::Line Driver::SysRW Pipe::Bidirectional);
+use POE qw(Wheel::ReadWrite Filter::Line Driver::SysRW Pipe::TwoWay);
# How many things to push through the pipe.
my $write_max = 10;
@@ -67,7 +67,7 @@ sub io_start {
# A pipe.
- my ($a_read, $b_write) = POE::Pipe::Unidirectional->new();
+ my ($a_read, $b_write) = POE::Pipe::TwoWay->new();
unless (defined $a_read) {
print "skip 2 # $@\n";
View
4 tests/07_event.t
@@ -23,7 +23,7 @@ BEGIN {
# Turn on all asserts.
sub POE::Kernel::ASSERT_DEFAULT () { 1 }
-use POE qw(Wheel::ReadWrite Filter::Line Driver::SysRW Pipe::Unidirectional);
+use POE qw(Wheel::ReadWrite Filter::Line Driver::SysRW Pipe::OneWay);
# Congratulate ourselves for getting this far.
print "ok 1\n";
@@ -35,7 +35,7 @@ sub io_start {
# A pipe.
- my ($a_read, $b_write) = POE::Pipe::Unidirectional->new();
+ my ($a_read, $b_write) = POE::Pipe::OneWay->new();
unless (defined $a_read) {
print "skip 2 # $@\n";
}
View
4 tests/19_filterchange.t
@@ -15,7 +15,7 @@ sub DEBUG () { 0 }
sub POE::Kernel::ASSERT_DEFAULT () { 1 }
use POE qw( Wheel::ReadWrite Driver::SysRW
Filter::Block Filter::Line Filter::Reference Filter::Stream
- Pipe::Bidirectional
+ Pipe::TwoWay
);
# Showstopper here. Try to build a pair of file handles. This will
@@ -25,7 +25,7 @@ use POE qw( Wheel::ReadWrite Driver::SysRW
# Socketpair. Read and write handles are the same.
my ($master_read, $master_write, $slave_read, $slave_write) =
- POE::Pipe::Bidirectional->new();
+ POE::Pipe::TwoWay->new();
unless (defined $master_read) {
&test_setup(0, "could not create a pipe in any form");
}
View
4 tests/21_gtk.t
@@ -40,7 +40,7 @@ warn( "\n",
# Turn on all asserts.
# sub POE::Kernel::TRACE_DEFAULT () { 1 }
sub POE::Kernel::ASSERT_DEFAULT () { 1 }
-use POE qw(Wheel::ReadWrite Filter::Line Driver::SysRW Pipe::Unidirectional);
+use POE qw(Wheel::ReadWrite Filter::Line Driver::SysRW Pipe::OneWay);
# How many things to push through the pipe.
my $write_max = 10;
@@ -65,7 +65,7 @@ sub io_start {
# A pipe.
- my ($a_read, $b_write) = POE::Pipe::Unidirectional->new();
+ my ($a_read, $b_write) = POE::Pipe::OneWay->new();
# Keep a copy of the unused handles so the pipes remain whole.
unless (defined $a_read) {
View
26 tests/22_wheel_run.t
@@ -12,10 +12,10 @@ use TestSetup;
# Turn on all asserts, and use POE and other modules.
sub POE::Kernel::ASSERT_DEFAULT () { 1 }
-use POE qw( Wheel::Run Filter::Line Pipe::Bidirectional Pipe::Unidirectional );
+use POE qw( Wheel::Run Filter::Line Pipe::TwoWay Pipe::OneWay );
-### Test unidirectional pipe() pipe.
-{ my ($uni_read, $uni_write) = POE::Pipe::Unidirectional->new('pipe');
+### Test one-way pipe() pipe.
+{ my ($uni_read, $uni_write) = POE::Pipe::OneWay->new('pipe');
if (defined $uni_read and defined $uni_write) {
&ok(1);
@@ -29,8 +29,8 @@ use POE qw( Wheel::Run Filter::Line Pipe::Bidirectional Pipe::Unidirectional );
}
}
-### Test unidirectional socketpair() pipe.
-{ my ($uni_read, $uni_write) = POE::Pipe::Unidirectional->new('socketpair');
+### Test one-way socketpair() pipe.
+{ my ($uni_read, $uni_write) = POE::Pipe::OneWay->new('socketpair');
if (defined $uni_read and defined $uni_write) {
&ok(3);
@@ -44,8 +44,8 @@ use POE qw( Wheel::Run Filter::Line Pipe::Bidirectional Pipe::Unidirectional );
}
}
-### Test unidirectional pair of inet sockets.
-{ my ($uni_read, $uni_write) = POE::Pipe::Unidirectional->new('inet');
+### Test one-way pair of inet sockets.
+{ my ($uni_read, $uni_write) = POE::Pipe::OneWay->new('inet');
if (defined $uni_read and defined $uni_write) {
&ok(5);
@@ -59,9 +59,9 @@ use POE qw( Wheel::Run Filter::Line Pipe::Bidirectional Pipe::Unidirectional );
}
}
-### Test bidirectional pipe.
+### Test two-way pipe.
{ my ($a_rd, $a_wr, $b_rd, $b_wr) =
- POE::Pipe::Bidirectional->new('pipe');
+ POE::Pipe::TwoWay->new('pipe');
if (defined $a_rd and defined $a_wr and defined $b_rd and defined $b_wr) {
&ok(7);
@@ -79,9 +79,9 @@ use POE qw( Wheel::Run Filter::Line Pipe::Bidirectional Pipe::Unidirectional );
}
}
-### Test bidirectional socketpair.
+### Test two-way socketpair.
{ my ($a_rd, $a_wr, $b_rd, $b_wr) =
- POE::Pipe::Bidirectional->new('socketpair');
+ POE::Pipe::TwoWay->new('socketpair');
if (defined $a_rd and defined $a_wr and defined $b_rd and defined $b_wr) {
&ok(10);
@@ -99,9 +99,9 @@ use POE qw( Wheel::Run Filter::Line Pipe::Bidirectional Pipe::Unidirectional );
}
}
-### Test bidirectional inet sockets.
+### Test two-way inet sockets.
{ my ($a_rd, $a_wr, $b_rd, $b_wr) =
- POE::Pipe::Bidirectional->new('inet');
+ POE::Pipe::TwoWay->new('inet');
if (defined $a_rd and defined $a_wr and defined $b_rd and defined $b_wr) {
&ok(13);
Please sign in to comment.
Something went wrong with that request. Please try again.