Permalink
Commits on Aug 19, 2005
  1. Abhishek Jain discovered a heretofore obscure socket leakage issue in

    POE::Component::Server::TCP.  New connection sockets were passed into
    callbacks as closures, preventing them from being closed timely on
    shutdown unless a session also exited.  This commit fixes the problem
    by passing new connections through POE::Session's args parameter
    rather than tying them up in closures.
    committed Aug 19, 2005
Commits on Aug 10, 2005
  1. Invoke event handlers in void context if the dispatcher is called in

    void context.  Previously handlers would be called in scalar context,
    causing a subtle edge case where objects wouldn't destruct properly.
    committed Aug 10, 2005
Commits on Aug 6, 2005
Commits on Jul 25, 2005
  1. Averell pointed out that callbacks via POE::Session->callback() do not

    return their handlers' return values to the caller.  This is directly
    contraindicated by the comments.  Furthermore, and perhaps best, he
    submitted a small patch to fix it and a proper regression test.  His
    report was 100% perfect in all regards (even if his patch was a little
    overzealous).  Be like him.
    committed Jul 25, 2005
Commits on Jul 5, 2005
Commits on Jul 1, 2005
  1. Apply Merijn Broeren's patch to SocketFactory for ActiveState Perl.

    This improves the non-blocking connect code by not turning
    non-blocking on for ALL sockets created in a process.  NBIO is only
    turned on for the ones created by the socket factory.
    committed Jul 1, 2005
  2. Cygwin under Virtual PC is just too many layers of emulation.

    Increase the timeout to avoid false failures.
    committed Jul 1, 2005
Commits on Jun 30, 2005
  1. Windows XP under Virtual PC is functional but teh sl0. Increase the

    "reasonable" time factor for the alarm tests in the face of such time
    dilation.
    committed Jun 30, 2005
  2. Work around Cygwin quirks in the tests. 1. syswrite() blocks on

    non-blocking pipes, so I moved a test over to internet domain sockets.
    2. close() on non-blocking sockets writes, so I changed a test to use
    shutdown() instead.  3. Files appear to be opened for exclusive access
    by default, so the Wheel::FollowTail tests can't run.  This closes
    rt.cpan.org tickets 11553 and 11053.
    committed Jun 30, 2005
  3. Preliminary fixes for coredumps when calling POE::Kernel->run() more

    than once.  Will be testing on OSX and ActiveState Perl before this is
    through.
    committed Jun 30, 2005
Commits on Jun 29, 2005
  1. Arturas Slajus (with diacriticals, however) reported a bug in POE's

    signal handling (rt.cpan.org ticket 12953).  This turned out to be
    caused by calling sig() outside a running session.  This change checks
    that methods requiring to be called from running sessions actually
    are, but it only does so when ASSERT_USAGE is enabled.
    committed Jun 29, 2005
  2. Lift POE::Filter::Reference's get() to POE::Filter, and modify most of

    the other POE::Filter subclasses to use it.  POE::Filter::HTTPD is an
    exception because it doesnt' have a get_one() function.
    POE::Filter::Stackable's get_one() was rewritten to accommodate the
    change.
    committed Jun 29, 2005
Commits on Jun 28, 2005
  1. Deprecate the stinky old TestSetup library in favor of the shiny, and

    way newer Test::More.  This finally resolves rt.cpan.org ticket 7558.
    committed Jun 28, 2005
Commits on Jun 27, 2005
  1. Modify get_one() to not destroy the reference's header in the buffer,

    in case it's a partial read and we switch the filter to something
    else.  In the past, the reference's header would be lost.
    committed Jun 27, 2005
Commits on Jun 10, 2005
  1. Make the POE::Filter::* classes inherit from POE::Filter despite that

    they don't use anything in POE::Filter.  This allows people to use
    isa() to determine whether things are POE::Filter classes.  Closes
    rt.cpan.org ticket #13146.
    
    Cleaned up the syntax somewhat in a few of the files.
    
    I removed a huge chunk of redundant code in POE::Filter::Reference by
    rewriting get() in terms of get_one_start() and get_one().  All tests
    pass.
    committed Jun 10, 2005
Commits on May 30, 2005
  1. Remove the unused ET_SIGNAL_COMPATIBLE and rename the explicit

    dispatch to ET_SIGNAL_RECURSIVE since that's what it is now.  This
    cleans up some vestiges from the signal deprecations.
    committed May 30, 2005
  2. Add a regression test to ensure recursive signal dispatch doesn't

    clobber signal parameters.
    committed May 30, 2005
  3. Put Jonathan Steinert's patch back. Fix recursive signal dispatch to

    use copies of @$etc rather than the original in nested _dispatch_event
    calls.  Any future recursive _dispatch_event calls will probably need
    to do the same.
    committed May 30, 2005
Commits on May 29, 2005
  1. Expose and document the new select() methods' arguments pass-through

    parameters.
    
    Modify Jonathan Steinert's @$etc clearing to preserve $_[ARG0] for
    signal events.  Recursive dispatch code really needs that.  I suspect
    that SIGCHLD dispatch is still broken, as many of the parameters
    passed down to it will be wiped out before the event is dispatched
    everywhere.
    committed May 29, 2005
  2. Modified the test for the internal _data_handle_add()'s new

    pass-through arguments parameter.
    committed May 29, 2005
  3. Add an Id tag. D'oh.

    committed May 29, 2005
  4. Add a regression test for hachi's last commit. His commit breaks

    something in SIGIDLE/SIGZOMBIE dispatch (k_aliases.t), and I want to
    be sure I fix that without regressing the issue he fixed.
    committed May 29, 2005
  5. Add pass-through parameters to POE::Kernel's select methods. Values

    passed in this way will be passed back with the I/O events they
    generate.
    committed May 29, 2005
Commits on May 25, 2005
  1. Arguments to an event should be cleaned up after the event is called,…

    … but before we return control back to the Kernel (queued events) or the calling Session (called events).
    Jonathan Steinert committed May 25, 2005
Commits on May 20, 2005
Commits on May 19, 2005
  1. Fall back to a single POE::Kernel->run() in this test because multiple

    entries were crashing ActivePerl + Tk.
    committed May 19, 2005
Commits on May 17, 2005
  1. Fix a miscount in the number of skipped tests under Windows. Also

    skip all tests when using Event, as it seems that Event +
    thread-simulated fork() + re-entering the event loop = Breakage.
    committed May 17, 2005