fact update parameter problem #449

Closed
breu opened this Issue Mar 19, 2013 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

breu commented Mar 19, 2013

Fact updating requires three positional arguments which are not obvious

root@breu-opencenter-server:~# opencentercli fact list | grep cpu_allocation_ratio
26 |16 |NovaCluster |cpu_allocation_ratio |

updating - broken:
root@breu-opencenter-server:~# opencentercli fact update 26 cpu_allocation_ratio 32
No fact found for id or name cpu_allocation_ratio

updating - working:
root@breu-opencenter-server:~# opencentercli fact update 26 26 32

Member

hughsaunders commented Mar 20, 2013

fixed in 541a221da5b09b9913bc4e24d5d7809d7a08d647
There shouldn't have been an 'id_or_name' argument as fact id is enough to identify a fact.

Member

hughsaunders commented Mar 20, 2013

modified version:

(default27)imac27:opencenterclient hms$ python shell.py fact update --help
usage: opencentercli fact update [-h] [--debug] [--endpoint ENDPOINT]
                                 fact_id value

positional arguments:
  fact_id              ID of fact to update
  value                new value

optional arguments:
  -h, --help           show this help message and exit
  --debug              Print debug information such as API requests
  --endpoint ENDPOINT  URL to opencenter endpoint. Should be of the form
                       http://host:8080 or https://user:pass@host:8443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment