Remove unnecessary default variables #1641

Merged
merged 1 commit into from Jan 4, 2017

Projects

None yet

3 participants

@alextricity25
Contributor
alextricity25 commented Dec 22, 2016 edited

This commit removes the following variables:

  • ssl_protocol and ssl_cipher_suite variables. These variables are
    already set to these values by default. Therefore there is no need
    to set them here.

  • *_ceilometer_enabled variables. OSA Newton now enables ceilometer
    based on whether the hosts are allocated in the inventory. Since
    we don't carry a ceilometer env.d file, these variables will
    automatically get set to False.

  • Removed unnecessary comment regarding apt_pinned_packages

  • Removed apply_security_hardening variable. There is no need to set
    this variable to true as that's already it's default value.

  • Removed the "cinder_service_backup_program_enabled: true" setting
    from deploy.sh. This variable is now automatically set to true
    when there are swift hosts present

  • Renamed the cinder_rpc_thread_pool_size variable to the proper
    name. See:
    rcbops/u-suk-dev#797 (comment)

Connects rcbops/u-suk-dev#797

@alextricity25
Contributor

recheck_all

@major
major approved these changes Jan 3, 2017 View changes

Changes look good to me. Waiting on Jenkins to do its thing.

@alextricity25 @alextricity25 alextricity25 Remove unnecessary default variables
This commit removes the following variables:

* ssl_protocol and ssl_cipher_suite variables. These variables are
  already set to these values by default. Therefore there is no need
  to set them here.

* *_ceilometer_enabled variables. OSA Newton now enables ceilometer
  based on wheater the hosts are allocated in the inventory. Since
  we don't carry a ceilometer env.d file, these variables will
  automatically get set to False.

* Removed unnecessary comment regarding apt_pinned_packages

* Removed apply_security_hardening variable. There is no need to set
  this variable to true as that's already it's default value.

* Removed the "cinder_service_backup_program_enabled: true" setting
  from deploy.sh. This variable is now automatically set to true
  when there are swift hosts present

* Renamed the cinder_rpc_thread_pool_size variable to the proper
  name. See:
  rcbops/u-suk-dev#797 (comment)
a485fb5
@Frank-ZhangXin
Contributor
Frank-ZhangXin commented Jan 4, 2017 edited

The commit message has minor typo:
2nd section: ...OSA Newton now enables ceilometer based on wheater the hosts are allocated in the inventory.
'wheater' should be 'whether'

@major
Contributor
major commented Jan 4, 2017

recheck_ceph

A single tempest test failed:

Body: {"itemNotFound": {"message": "Volume 5a912f14-a129-4135-80cb-64204c21baca could not be found.", "code": 404}}
@major
major approved these changes Jan 4, 2017 View changes
@Frank-ZhangXin

LGTM

@Frank-ZhangXin Frank-ZhangXin merged commit 558c1b7 into master Jan 4, 2017

4 checks passed

ceph Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
swift Build finished.
Details
@major major deleted the cantu/u-suk-dev/issue/797 branch Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment