Fix deprecation warnings & errors in MaaS #1650

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@major
Contributor
major commented Jan 4, 2017 edited

This patch fixes some deprecation warnings for bare variables and fixes
an error that stops the playbook when no servers are in the swift_proxy
group.

A few other cleanups of when: conditionals are also included.

Connects rcbops/rpc-openstack#1647

@major major Fix deprecation warnings & errors in MaaS
This patch fixes some deprecation warnings for bare variables and fixes
an error that stops the playbook when no servers are in the swift_proxy
group.

A few other cleanups of `when:` conditionals are also included.

Connects: rcbops/rpc-openstack#1647
d2e768c
@major major self-assigned this Jan 4, 2017
@d34dh0r53
Contributor

This looks good and I prefer the list format over the and format that is used in #1648, perhaps we can combine the two PRs. For now I'll give this one a 👍 as #1648 needs more work.

@major major requested a review from d34dh0r53 Jan 4, 2017
@BjoernT
Contributor
BjoernT commented Jan 4, 2017

@d34dh0r53 I merged the style from this PR into #1648

@d34dh0r53

Looks good to me!

@major
Contributor
major commented Jan 5, 2017

I'll close this up since #1648 is moving along. I didn't see the other PR originally because it wasn't attached to the waffle card. ;)

@major major closed this Jan 5, 2017
@major major deleted the mhayden-1647 branch Jan 5, 2017
@BjoernT
Contributor
BjoernT commented Jan 5, 2017

@major no waffles for you, lol. I guess we need to look how to cover PRs as part of the waffle board but also we had no bug tracking meetings due to the holidays. Maybe as simple as that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment