New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a troubleshooting section to the README file #2052

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@adaszko
Copy link
Collaborator

adaszko commented Dec 28, 2018

@adaszko

This comment has been minimized.

Copy link
Collaborator

adaszko commented Dec 28, 2018

bors try

bors bot added a commit that referenced this pull request Dec 28, 2018

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Dec 28, 2018

Add checking for container exit code at the end of tests

Every custom test harness ever, after at least a month of being used 😂

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Dec 28, 2018

@adaszko adaszko force-pushed the masked-bootstrap-137-exit-code branch from f60a6f5 to ffbae3a Dec 28, 2018

@adaszko

This comment has been minimized.

Copy link
Collaborator

adaszko commented Dec 28, 2018

bors try

bors bot added a commit that referenced this pull request Dec 28, 2018

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Dec 28, 2018

@adaszko adaszko force-pushed the masked-bootstrap-137-exit-code branch from ffbae3a to b6879d7 Jan 3, 2019

@adaszko

This comment has been minimized.

Copy link
Collaborator

adaszko commented Jan 3, 2019

bors try

bors bot added a commit that referenced this pull request Jan 3, 2019

@adaszko

This comment has been minimized.

Copy link
Collaborator

adaszko commented Jan 3, 2019

bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2019

try

Not awaiting review

@adaszko adaszko requested a review from ArturGajowy Jan 3, 2019

@adaszko

This comment has been minimized.

Copy link
Collaborator

adaszko commented Jan 3, 2019

bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2019

try

Not awaiting review

@adaszko adaszko force-pushed the masked-bootstrap-137-exit-code branch from 6eda894 to dd7f5d8 Jan 3, 2019

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

bors try ?

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2019

try

Not awaiting review

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2019

try

Not awaiting review

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

This is very strange. I've done the 'sync pull requests' thing they advise in here:
https://forum.bors.tech/t/what-does-it-mean-if-bors-responds-with-not-awaiting-review/132

But it doesn't seem to help.

Maybe close this PR and reopen a new one?

@ArturGajowy ArturGajowy closed this Jan 3, 2019

@ArturGajowy ArturGajowy reopened this Jan 3, 2019

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

(missclick, sorry)

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2019

try

Not awaiting review

@ArturGajowy

This comment has been minimized.

@ArturGajowy
Copy link
Collaborator

ArturGajowy left a comment

LGTM but check the comments :)

@@ -132,6 +140,24 @@ def get_rnode_address(self) -> str:
def get_metrics(self):
return self.shell_out('curl', '-s', 'http://localhost:40403/metrics')

def get_connected_peers_metric_value(self):
try:
return self.shell_out('sh', '-c', 'curl -s http://localhost:40403/metrics | grep ^rchain_comm_rp_connect_peers\\ ')

This comment has been minimized.

@ArturGajowy

ArturGajowy Jan 3, 2019

Collaborator

does this pipe-fail?

status = self.container.wait(timeout=1)
except requests.exceptions.ReadTimeout:
# Container is still running: let the test case body decide whether the test succeeded or not
return

This comment has been minimized.

@ArturGajowy

ArturGajowy Jan 3, 2019

Collaborator

What happens if this branch is hit during cleanup?

Anyway, the function name is lying ATM: it doesn't really ensure there is a status code. It should either fail for unavailable status codes, or return an option-like value saying None (vs Some(true/false) normally) and be called check_exit_code. Yeah I know that's not how one does Python. I hate the fact that the callers of this function need to know its internals and have to know that this function needs to be called in a loop, as cleanup seems to do.

Change my mind.

This comment has been minimized.

@adaszko

adaszko Jan 3, 2019

Collaborator

The do-not-merge-yet label should really say do-not-review-yet. I added you as a reviewer because I thought that would help with bors problems. This PR isn't fully baked yet. I needed a way to run integration tests on CI.

This comment has been minimized.

@ArturGajowy

ArturGajowy Jan 3, 2019

Collaborator

You can create such a label. Or just tell me that you used me in hopes of unclogging bors :*

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

bors try?

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2019

try

Not awaiting review

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2019

try

Timed out

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

It seems bors try was not working because there already was a try build being run.

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

Just had an idea

bors r-

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

Nah, I think I remember there being a thread saying bors r- a.k.a. cancel only works for r+ builds, and not try-s. Let's

bors try

anyway

bors bot added a commit that referenced this pull request Jan 3, 2019

@ArturGajowy

This comment has been minimized.

Copy link
Collaborator

ArturGajowy commented Jan 3, 2019

🤔

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2019

@adaszko

This comment has been minimized.

Copy link
Collaborator

adaszko commented Jan 4, 2019

It seems bors try was not working because there already was a try build being run.

That was my conclusion as well.

@adaszko adaszko force-pushed the masked-bootstrap-137-exit-code branch from dd7f5d8 to dc2935d Jan 4, 2019

@adaszko

This comment has been minimized.

Copy link
Collaborator

adaszko commented Jan 4, 2019

bors try

bors bot added a commit that referenced this pull request Jan 4, 2019

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 4, 2019

@adaszko adaszko force-pushed the masked-bootstrap-137-exit-code branch from dc2935d to d1d8b5d Jan 7, 2019

@adaszko adaszko removed the do-not-merge label Jan 7, 2019

@adaszko adaszko changed the title Add checking for container exit code at the end of tests Add a troubleshooting section to the README file Jan 7, 2019

@adaszko

This comment has been minimized.

Copy link
Collaborator

adaszko commented Jan 7, 2019

bors r+

bors bot added a commit that referenced this pull request Jan 7, 2019

Merge #2052
2052: Add a troubleshooting section to the README file r=adaszko a=adaszko

https://rchain.atlassian.net/browse/RCHAIN-2789

Co-authored-by: Adam Szkoda <adaszko@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 7, 2019

@bors bors bot merged commit d1d8b5d into dev Jan 7, 2019

2 of 3 checks passed

continuous-integration/drone/pr the build failed
Details
bors Build succeeded
Details
continuous-integration/drone/push the build was successful
Details

@bors bors bot deleted the masked-bootstrap-137-exit-code branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment