RCHAIN-4103: Set fault tolerance as 1 for VALID old blocks [v0.9.23LTS] #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrospic
approved these changes
May 11, 2020
| 1f.pure[F], | ||
| SafetyOracle[F] | ||
| .normalizedFaultTolerance(dag, block.blockHash) | ||
| ) // TODO: Warn about parent block finalization |
There was a problem hiding this comment.
I cannot imagine what this might mean
zsluedem
approved these changes
May 12, 2020
| normalizedFaultTolerance <- SafetyOracle[F] | ||
| .normalizedFaultTolerance(dag, block.blockHash) // TODO: Warn about parent block finalization | ||
| // TODO this is temporary solution to not calculate fault tolerance for old blocks which is costly | ||
| oldBlock = dag.latestBlockNumber.map(_ - block.body.state.blockNumber).map(_ > 100) |
There was a problem hiding this comment.
Actually I don't like the hardcoded value here. Butnvm, let's fix it first
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 13, 2020
2932: Set fault tolearnce as 1 for old blocks r=nzpr a=nzpr Don't calculate fault tolerance for old blocks, temporary fix. ### Please make sure that this PR: - [x] is at most 200 lines of code (excluding tests), - [x] meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards), - [x] includes tests for all added features, - [x] has a reviewer assigned, - [x] has [all commits signed](https://rchain.atlassian.net/wiki/spaces/DOC/pages/498630673/How+to+sign+commits+to+rchain+rchain). ### [Bors](https://bors.tech/) cheat-sheet: - `bors r+` runs integration tests and merges the PR (if it's approved), - `bors try` runs integration tests for the PR, - `bors delegate+` enables non-maintainer PR authors to run the above. Co-authored-by: nutzipper <1746367+nzpr@users.noreply.github.com>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 20, 2020
2932: Set fault tolearnce as 1 for old blocks r=nzpr a=nzpr Don't calculate fault tolerance for old blocks, temporary fix. ### Please make sure that this PR: - [x] is at most 200 lines of code (excluding tests), - [x] meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards), - [x] includes tests for all added features, - [x] has a reviewer assigned, - [x] has [all commits signed](https://rchain.atlassian.net/wiki/spaces/DOC/pages/498630673/How+to+sign+commits+to+rchain+rchain). ### [Bors](https://bors.tech/) cheat-sheet: - `bors r+` runs integration tests and merges the PR (if it's approved), - `bors try` runs integration tests for the PR, - `bors delegate+` enables non-maintainer PR authors to run the above. Co-authored-by: nutzipper <1746367+nzpr@users.noreply.github.com>
|
Timed out. |
9rb
changed the title
5 tasks
tgrospic
changed the title
tgrospic
changed the title
|
Closed as superseded by #2947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Don't calculate fault tolerance for old blocks, temporary fix.
JIRA ticket:
https://rchain.atlassian.net/browse/RCHAIN-4103
Please make sure that this PR:
Bors cheat-sheet:
bors r+runs integration tests and merges the PR (if it's approved),bors tryruns integration tests for the PR,bors delegate+enables non-maintainer PR authors to run the above.