Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCHAIN-4089: Add configs for api server #2933

Merged
merged 2 commits into from May 18, 2020

Conversation

zsluedem
Copy link
Collaborator

@zsluedem zsluedem commented May 12, 2020

Overview

This PR adds additional config for gRPC API servers to control connection timeout.

JIRA ticket:

https://rchain.atlassian.net/browse/RCHAIN-4089

Please make sure that this PR:

Bors cheat-sheet:

  • bors r+ runs integration tests and merges the PR (if it's approved),
  • bors try runs integration tests for the PR,
  • bors delegate+ enables non-maintainer PR authors to run the above.

@zsluedem zsluedem changed the title RCHAIN-4089add configs for api server like keepalive, keepaliveTimeout, maxConne… RCHAIN-4089add configs for api server May 12, 2020
@zsluedem zsluedem requested review from nzpr and tgrospic May 12, 2020 03:26
@zsluedem zsluedem force-pushed the RCHAIN-4089-config-api-network branch from cf402d6 to 0cd2625 Compare May 12, 2020 05:46
@zsluedem zsluedem force-pushed the RCHAIN-4089-config-api-network branch from 0cd2625 to fd280b8 Compare May 12, 2020 17:12
@zsluedem zsluedem requested a review from tgrospic May 12, 2020 17:14
Copy link
Collaborator

@tgrospic tgrospic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zsluedem
Copy link
Collaborator Author

zsluedem commented May 13, 2020

@tgrospic I just want to tell you that I add one more commit to put the param in the http server also 8366141 .Hope you don't mind

@zsluedem
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 15, 2020

👎 Rejected by too few approved reviews

Copy link
Collaborator

@nzpr nzpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that default values in conf file are defaults for grpc, lets keep it that way.

@nzpr
Copy link
Collaborator

nzpr commented May 15, 2020

bors r+

bors bot added a commit that referenced this pull request May 15, 2020
2933: RCHAIN-4089add configs for api server r=nzpr a=zsluedem




Co-authored-by: Will Qiu <zsluedem06@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 15, 2020

Build failed:

@zsluedem
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request May 16, 2020
2933: RCHAIN-4089add configs for api server r=zsluedem a=zsluedem




Co-authored-by: Will Qiu <zsluedem06@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 16, 2020

Build failed:

@zsluedem
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 18, 2020

Build succeeded:

@bors bors bot merged commit 28179f0 into rchain:dev May 18, 2020
@zsluedem zsluedem deleted the RCHAIN-4089-config-api-network branch May 19, 2020 01:05
@9rb 9rb added the next-release Ready for next release label Jun 3, 2020
@9rb 9rb changed the title RCHAIN-4089add configs for api server RCHAIN-4089: Add configs for api server Jun 4, 2020
@tgrospic tgrospic added this to the v0.9.25 milestone Jun 19, 2020
@9rb 9rb removed the next-release Ready for next release label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants