Fix sync and migration on compacted state

[nzpr]

Overview

Closes #3471

Notes

Please make sure that this PR:

• is at most 200 lines of code (excluding tests),
• meets RChain development coding standards,
• includes tests for all added features,
• has a reviewer assigned,
• has all commits signed.

Bors cheat-sheet:

• bors r+ runs integration tests and merges the PR (if it's approved),
• bors try runs integration tests for the PR,
• bors delegate+ enables non-maintainer PR authors to run the above.

[nzpr]

On compacted state finalized block set during migration were including edge blocks parents, which do not exist in metadata store. Fix is filtering them out.

[nzpr]

We have to add LFB first, because each DagStore.insert returns DagRepresentation, which requires having finalized block in DagStore. Also each insert checks consistency of the DAG (heights should be continuous)

rchain/block-storage/src/main/scala/coop/rchain/blockstorage/dag/BlockMetadataStore.scala

Lines 186 to 192 in 56c35c0

	private def validateDagState(state: DagState): DagState = {
	// Validate height map index (block numbers) are in sequence without holes
	val m = state.heightMap
	val (min, max) = if (m.nonEmpty) (m.firstKey, m.lastKey + 1) else (0L, 0L)
	assert(max - min == m.size.toLong, "DAG store height map has numbers not in sequence.")
	state
	}

So fix is to add blocks in reverse order - down from LFB.

[tgrospic]

LGTM

[zsluedem]

LGTM

[nzpr]

bors merge

[bors]

Build succeeded:

• bors build finished