Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE comment helper: [sitename].meta.stackexchange.com links are not handled. #87

Open
mjpieters opened this issue Jan 22, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@mjpieters
Copy link

commented Jan 22, 2019

During the big SSL changeover, Meta sites moved from meta.[site].stackexchange.com to [site].meta.stackexchange.com, see Why are per-site metas under the meta.stackexchange domain instead of their main site's domain?

But the validSites regexp regards those links as invalid, only meta.[site].stackexchange.com is sanctioned.

Can this be updated so we can link to per-site meta posts on all sites in the network?

@ron-reaser

This comment has been minimized.

Copy link

commented Mar 18, 2019

I believe the corrected regex should be as follows:
^(?:(?:(?:meta\.)?(?:stackoverflow|serverfault|askubuntu|superuser))|(?:[^.]+\.(?:meta\.)?stackexchange)|stackapps)\.com$

I think that accounts for the change in the location of meta in per-site meta links, and I've tested it successfully on rpg.stackexchange.com and rpg.meta.stackexchange.com

I don't think the following change is necessary, but the // @match *://*.meta.stackexchange.com/* might also need to be added at the top of the userscript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.