Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rclone/rclone
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.52.2
Choose a base ref
...
head repository: rclone/rclone
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.52.3
Choose a head ref
  • 19 commits
  • 26 files changed
  • 6 contributors

Commits on Jun 25, 2020

  1. serve dlna: Fix file list on Samsung Series 6+ TVs

    This fixes the command "serve dlna" in order correctly show the list
    of files on Samsung TV models starting from Series 6.
    ilteoood authored and ncw committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    d805e63 View commit details
    Browse the repository at this point in the history
  2. doc: disable smart typography (eg en-dash) in MANUAL.* and man page

    Before this change MANUAL.html and rclone.1 would show flags like –addr
    
    Now it shows --addr which is easy to copy and paste.
    
    This was pointed out in #4362
    ncw committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    1f279f0 View commit details
    Browse the repository at this point in the history
  3. drive: Allow the use of --drive-impersonate with the root_folder_id "…

    …appDataFolder"
    
    In this commit
    
    5c5ad62 drive: fix --drive-impersonate with cached root_folder_id
    
    We disabled the use of root_folder_id with --drive-impersonate to fix
    a problem with a cached root_folder_id giving the wrong results.
    
    This, alas, broke one users setup with a root_folder_id of
    appDataFolder. Since this is identifiable and definitely couldn't have
    been cached, we can safely skip this check in this case.
    
    See: https://forum.rclone.org/t/rclone-gdrive-no-longer-returning-anything/17215/10
    ncw committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    d745bc1 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Configuration menu
    Copy the full SHA
    687865f View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. onedrive: Fix reverting to Copy when Move would have worked

    For some objects the onedrive backend has been doing a server side
    copy and a delete when a server side move would have worked OK.
    
    This was caused by not detecting the home drive correctly (when it was
    an empty string) and assuming that these transfers were cross drive.
    
    This is fixed by comparing canonicalizing drive IDs before comparing them.
    ncw committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    a9ffa11 View commit details
    Browse the repository at this point in the history
  2. fs/cache: fix moveto/copyto remote:file remote:file2

    Before this change, if the cache was given a source `remote:file` it
    stored `remote:` with the error `fs.ErrorIsFile` attached. This meant
    that if it `remote:` was subsequently looked up it would return the
    `fs.ErrorIsFile` error.
    
    This broke `moveto remote:file remote:file2` as moveto would lookup
    `remote:` from the second argument and erroneously get the
    `fs.ErrorIsFile` error.
    
    This likely broke other commands too.
    
    This was broken in
    
    4c98360 fs/cache: Add Pin and Unpin and canonicalised lookup
    
    Which was released in v1.52.0
    
    The fix is to make a new cache entry for `remote:` with no error
    attached in the case that the original call returned `fs.ErrorIsFile`.
    ncw committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    6760ab6 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. drive: make dangling shortcuts appear in listings

    Previous to this a dangling shortcut would error the directory
    listing.
    
    This patch makes dangling shortcuts appear as 0 sized objects in the
    directory listing so they can be deleted. These objects can't be read
    though.
    ncw committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    5c0af62 View commit details
    Browse the repository at this point in the history
  2. pcloud: fix oauth on European region "eapi.pcloud.com"

    Pcloud appears to have opened up a new region and they are returning
    the hostname in the oauth callback, thus
    
        GET /?code=XXX&locationid=1&hostname=api.pcloud.com&state=XXX HTTP/1.1
        GET /?code=XXX&locationid=2&hostname=eapi.pcloud.com&state=XXX HTTP/1.1
    
    This isn't documented yet, however pCloud have confirmed that this is
    the correct interpretation.
    
    Rclone now reads the "hostname" parameter in the oauth callback and
    stores it in the config file. It uses it for all subequent API calls.
    ncw committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    3278b29 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. s3: fix bucket Region auto detection when Region unset in config #2915

    Previous to this fix if Region was not set and Endpoint was not set
    then we set the endpoint to "https://s3.amazonaws.com/".
    
    This is unecessary because if the Region alone isn't set then we set
    it to "us-east-1" which has the same endpoint.
    
    Having the endpoint set breaks the bucket region auto detection with
    the error "Failed to update region for bucket: can't set region to
    "xxx" as endpoint is set".
    
    This fix removes that check.
    ncw committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    4f84726 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Avoid comma rendered in URL in onedrive.md (#4438)

    Removed comma from the end of the Azure AD Applications List Blade URL since it was not resolving and customers were opening up support tickets with the Microsoft Azure AD team.
    kjyam98 authored and ncw committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    8156432 View commit details
    Browse the repository at this point in the history
  2. make_manual: Support SOURCE_DATE_EPOCH

    The documentation contains an embedded datetime which do not read
    SOURCE_DATE_EPOCH. This makes the documentation unreproducible when
    distribution tries to recreate previous build of the package.
    
    This patch ensures we attempt to read the environment variable before
    default to the current build time.
    
    Signed-off-by: Morten Linderud <morten@linderud.pw>
    Foxboron authored and ncw committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    e8222bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d45c6e View commit details
    Browse the repository at this point in the history
  4. docs: Update install.md to reflect minimum Go version

    Fixes #3765
    eharris authored and ncw committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    ace56b6 View commit details
    Browse the repository at this point in the history
  5. docs: workaround and policy for Google Drive API

    * workaround for Google Drive API
    * mention the use of Google User Data
    * unified wording for user data policy
    dustalov authored and ncw committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    c0e9584 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. sync: fix deadlock with --track-renames-strategy modtime - fixes #4427

    Before this change we could exit the popRenameMap function with the
    lock held.
    
    This fixes the problem by defer-ring the unlock.
    
    See: https://forum.rclone.org/t/track-renames-strategy-modtime-doesnt-work/16992
    ncw committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    f949856 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. drive: drop "Disabling ListR" messages down to debug

    This was causing unecessary anguish for users since these messages are
    harmless and really only interesting for debugging.
    
    See: https://forum.rclone.org/t/rclone-gdrive-error/18098
    ncw committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    fb2a4ed View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. docs: update install from source instructions

    This has changed post Go modules.
    
    In particular it recommends against the go get `-u` flag.
    
    See: https://forum.rclone.org/t/install-from-source-go-get-errors/18114
    ncw committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    073e996 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2020

  1. drive: stop using root_folder_id as a cache #4419

    Previous to this change rclone cached the looked up root_folder_id in
    the root_folder_id config variable.
    
    This has caused a lot of confusion and a few attempts at workarounds
    and ultimately was a mistake.
    
    This reverts rclone attempting to cache anything in root_folder_id and
    returns that variable to be entirely user modified.
    
    It gives a little hint in the debug that rclone could be sped up
    slightly by setting it, but it is up to the user to think about
    whether that would be OK or not.
    
        Google drive root '': root_folder_id = "XXX" - save this in the config to speed up startup
    
    It does not change root_folder_id itself, leaving this to the user.
    
    See: https://forum.rclone.org/t/rclone-gdrive-no-longer-returning-anything/17215
    ncw committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    029f817 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Version v1.52.3

    ncw committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    729799a View commit details
    Browse the repository at this point in the history
Loading