Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement link sharing for all remotes that support it #2178

Open
breunigs opened this issue Mar 24, 2018 · 6 comments

Comments

@breunigs
Copy link
Collaborator

commented Mar 24, 2018

in #2176 link sharing support was added for some remotes. This is a tracking ticket to add it for all other remotes that support it:

  • Amazon Drive
  • Amazon S3
  • Backblaze B2
  • Box
  • Dropbox
  • FTP
  • Google Cloud Storage
  • Google Drive
  • HTTP - this should be trivial - just return the URL
  • Hubic
  • Jottacloud
  • Mega
  • Microsoft Azure Blob Storage
  • Microsoft OneDrive
  • Openstack Swift
  • OpenDrive
  • pCloud
  • QingStor
  • SFTP
  • WebDAV
  • Yandex Disk
  • The local filesystem

checkmark means that this remote was considered. If it's strike-through, then the remote cannot support it.

@ncw ncw added the enhancement label Mar 26, 2018

@ncw ncw added this to the Soon milestone Mar 26, 2018

@ncw ncw added the help wanted label Mar 26, 2018

buengese added a commit to buengese/rclone that referenced this issue Aug 28, 2018

ncw added a commit that referenced this issue Sep 4, 2018

@theblackhole

This comment has been minimized.

Copy link

commented Oct 4, 2018

This might help for Openstack Swift implementation :

From what I could understand, there are two types of urls :

jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 4, 2018

jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 4, 2018

jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 4, 2018

jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 4, 2018

jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 5, 2018

@ncw

This comment has been minimized.

Copy link
Collaborator

commented Oct 6, 2018

@theblackhole thanks for that. The first is probably what we want I think. Do you fancy making a pull request to implement?

@theblackhole

This comment has been minimized.

Copy link

commented Oct 6, 2018

@ncw Unfortunatly I don't know Golang but I may try when I got time.

Cnly added a commit that referenced this issue Oct 9, 2018

@xiaolei0125

This comment has been minimized.

Copy link

commented Oct 11, 2018

@ncw
This might help for implement link sharing for Amazon S3 Compliant Storage Providers (AWS, Ceph, Dreamhost, IBM COS, Minio, OSS):
s3_presigned_url.go

Using presigned url for link sharing, no matter the S3 bucket is private or public.
Notice: the presigned url needs to specify the expiration time.

I have test this presigned url code with Minio and OSS(S3 Compliant), all are work fine.
The presigned url look like this:
http://x.x.x.x:9000/mybucket/my.jpg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=CBDDBNRX5G91RTOM20K2%2F20181011%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20181011T075806Z&X-Amz-Expires=900&X-Amz-SignedHeaders=host&X-Amz-Signature=d1c6835e991765c63ef64560f4f6e5b1c6679610a9791f2d5db70a9bbd51a25a

Is there a way to integrate presigned url into rclone link for Amazon S3 Compliant Storage Providers ?

Below is my code for reference:
s3_presigned_url.txt

@ncw

This comment has been minimized.

Copy link
Collaborator

commented Oct 14, 2018

@xiaolei0125 would you like to send a pull request for this?

If you implement the PublicLink optional method in the s3 backend with the code above that should be it!

For the time being put a really long expires on it and we can work out how to pass the desired expiry time in a second PR.

@xiaolei0125

This comment has been minimized.

Copy link

commented Oct 15, 2018

@ncw Ok, I've been a bit busy recently, I may try when I got time.

buengese added a commit to buengese/rclone that referenced this issue Nov 19, 2018

yandex: complete rewrite
Get rid of the api client and use rest/pacer for all API calls
Add Copy, Move, DirMove, PublicLink, About optional interfaces
Improve general error handling
Remove ListR for now due to inconsitent behaviour
fixes rclone#2586, progress on rclone#2740 and rclone#2178

buengese added a commit to buengese/rclone that referenced this issue Nov 20, 2018

yandex: complete rewrite
Get rid of the api client and use rest/pacer for all API calls
Add Copy, Move, DirMove, PublicLink, About optional interfaces
Improve general error handling
Remove ListR for now due to inconsitent behaviour
fixes rclone#2586, progress on rclone#2740 and rclone#2178

ncw added a commit that referenced this issue Nov 22, 2018

yandex: complete rewrite
Get rid of the api client and use rest/pacer for all API calls
Add Copy, Move, DirMove, PublicLink, About optional interfaces
Improve general error handling
Remove ListR for now due to inconsitent behaviour
fixes #2586, progress on #2740 and #2178

poundifdef added a commit to poundifdef/rclone that referenced this issue Nov 27, 2018

yandex: complete rewrite
Get rid of the api client and use rest/pacer for all API calls
Add Copy, Move, DirMove, PublicLink, About optional interfaces
Improve general error handling
Remove ListR for now due to inconsitent behaviour
fixes rclone#2586, progress on rclone#2740 and rclone#2178

yparitcher added a commit to yparitcher/rclone that referenced this issue Jun 30, 2019

yparitcher added a commit to yparitcher/rclone that referenced this issue Jun 30, 2019

@yparitcher yparitcher referenced this issue Jun 30, 2019
5 of 5 tasks complete

yparitcher added a commit to yparitcher/rclone that referenced this issue Jun 30, 2019

yparitcher added a commit to yparitcher/rclone that referenced this issue Jul 1, 2019

yparitcher added a commit to yparitcher/rclone that referenced this issue Jul 1, 2019

yparitcher added a commit to yparitcher/rclone that referenced this issue Jul 2, 2019

yparitcher added a commit to yparitcher/rclone that referenced this issue Jul 3, 2019

ncw added a commit that referenced this issue Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.