VFS doesn't update mtime for directories

[lorenz]

What is the problem you are having with rclone?

I'm using serve webdav to serve a local directory over WebDAV. This works fine except that the VFS layer doesn't update the mtime (ModTime) of directories even after dir-cache-time has expired. Debugging revealed that the problem is in dir.go:635 where rclone reuses node (which has the old modTime), item (the new value with the correct modTime) is just discarded.

I'm not familiar with the design principles of the rclone VFS layer so I'm not sure what the right fix here is.

What is your rclone version (output from rclone version)

Self-built from revision 2f461f1

Which OS you are using and how many bits (e.g. Windows 7, 64 bit)

Linux x86_64

[ncw]

Ah, you mean this code

rclone/vfs/dir.go

Lines 633 to 637 in 2f461f1

	case fs.Directory:
	// Reuse old dir value if it exists
	if node == nil || !node.IsDir() {
	node = newDir(d.vfs, d.f, d, item)
	}

This needs to do the equivalent of what happens to the file in the lines above

rclone/vfs/dir.go

Lines 627 to 632 in 2f461f1

	// Reuse old file value if it exists
	if file, ok := node.(*File); node != nil && ok {
	file.setObjectNoUpdate(obj)
	} else {
	node = newFile(d, d.path, obj, name)
	}

So it needs to call an equivalent of this

rclone/vfs/file.go

Lines 465 to 471 in 2f461f1

	// Update the object but don't update the directory cache - for use by
	// the directory cache
	func (f *File) setObjectNoUpdate(o fs.Object) {
	f.mu.Lock()
	f.o = o
	f.mu.Unlock()
	}

Note that we don't want to just make a new directory node as that will cause there to be two nodes pointing to the same directory which will cause trouble later!

It should be a fairly easy patch if you want to have a go?