Sync directory modification time and metadata on the root of the sync #7652
Labels
Comments
nielash
added a commit
to nielash/rclone
that referenced
this issue
Mar 4, 2024
Before this change, operations.CopyDirMetadata would fail with: `internal error: expecting directory string from combine root '' to have SetMetadata method: optional feature not implemented` if the dst was the root directory of a combine upstream. This is because combine was returning a *fs.Dir, which does not satisfy the fs.SetMetadataer interface. While it is true that combine cannot set metadata on the root of an upstream (see also rclone#7652), this should not be considered an error that causes sync to do high-level retries, abort without doing deletes, etc. This change addresses the issue by creating a new type of DirWrapper that is allowed to fail silently, for exceptional cases such as this where certain special directories have more limited abilities than what the Fs usually supports. It is possible that other similar wrapping backends (Union?) may need this same fix.
nielash
added a commit
to nielash/rclone
that referenced
this issue
Mar 5, 2024
Before this change, operations.CopyDirMetadata would fail with: `internal error: expecting directory string from combine root '' to have SetMetadata method: optional feature not implemented` if the dst was the root directory of a combine upstream. This is because combine was returning a *fs.Dir, which does not satisfy the fs.SetMetadataer interface. While it is true that combine cannot set metadata on the root of an upstream (see also rclone#7652), this should not be considered an error that causes sync to do high-level retries, abort without doing deletes, etc. This change addresses the issue by creating a new type of DirWrapper that is allowed to fail silently, for exceptional cases such as this where certain special directories have more limited abilities than what the Fs usually supports. It is possible that other similar wrapping backends (Union?) may need this same fix.
ncw
pushed a commit
that referenced
this issue
Mar 7, 2024
Before this change, operations.CopyDirMetadata would fail with: `internal error: expecting directory string from combine root '' to have SetMetadata method: optional feature not implemented` if the dst was the root directory of a combine upstream. This is because combine was returning a *fs.Dir, which does not satisfy the fs.SetMetadataer interface. While it is true that combine cannot set metadata on the root of an upstream (see also #7652), this should not be considered an error that causes sync to do high-level retries, abort without doing deletes, etc. This change addresses the issue by creating a new type of DirWrapper that is allowed to fail silently, for exceptional cases such as this where certain special directories have more limited abilities than what the Fs usually supports. It is possible that other similar wrapping backends (Union?) may need this same fix.
5 tasks
Fornax96
pushed a commit
to Fornaxian/rclone
that referenced
this issue
Jul 30, 2024
Before this change, operations.CopyDirMetadata would fail with: `internal error: expecting directory string from combine root '' to have SetMetadata method: optional feature not implemented` if the dst was the root directory of a combine upstream. This is because combine was returning a *fs.Dir, which does not satisfy the fs.SetMetadataer interface. While it is true that combine cannot set metadata on the root of an upstream (see also rclone#7652), this should not be considered an error that causes sync to do high-level retries, abort without doing deletes, etc. This change addresses the issue by creating a new type of DirWrapper that is allowed to fail silently, for exceptional cases such as this where certain special directories have more limited abilities than what the Fs usually supports. It is possible that other similar wrapping backends (Union?) may need this same fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently rclone does not sync directory modification time and metadata on the root of the sync.
The syncing was implemented in #6685 and there @nielash noted that the root modification times and metadata weren't being synced.
This is quite hard to fix as there is no way of getting an
fs.Directoryobject for the root from the backend at the moment.This probably needs a
NewEntrymethod to replace or extendNewObject, or it needsNewFsto return the root directory entry.This is the same problem that
rclone lsjson --stat remote:has - this has no information on the root directory.PS When this is fixed, take out the notes in
cmd/{sync,copy,move}pointing to this issueHow to use GitHub
The text was updated successfully, but these errors were encountered: