Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jottacloud: use new api for retrieving internal username - fixes #3434 #3436

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@buengese
Copy link
Collaborator

commented Aug 13, 2019

Looks like jottacloud is slowly transitioning to their new API and disabled the usage of the email address as username for JFS API. Don't merge this immediately Jottacloud's config function is getting dangerously close to spaghetti code and I consider using this PR to clean that up a bit.

@ncw

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

Those changes look good to me. Provided it passes the integration tests, I suggest you merge :-)

@buengese

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 13, 2019

Yeah you're probably right. Tests pass I'll merge this. I'll do another PR for some refactoring and cleanup of the jottacloud backend later.

@buengese buengese merged commit 6f4b86e into rclone:master Aug 13, 2019

4 checks passed

GolangCI No issues found!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rclone.rclone Build #20190813.5 succeeded with issues
Details
@ProphetSe7en

This comment has been minimized.

Copy link

commented Aug 14, 2019

So we have to wait for a new release of rclone, or is there something I can do to add this fix manually?

@buengese

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 14, 2019

This is available right now. Just download the latest beta from https://beta.rclone.org/

@buengese buengese deleted the buengese:fix-jotta branch Aug 14, 2019

@zotune

This comment has been minimized.

Copy link

commented Aug 15, 2019

it works again now, but wasn't working this morning. will let you know if problem persists.
thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.