Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container fixes #3544

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@mateidavid
Copy link
Contributor

commented Sep 17, 2019

What is the purpose of this change?

Specifically:

  • enable Docker container userspace operation
  • enable Docker userspace mount exposed to the host
  • add more Docker image usage documentation

The changes affect only the Docker image. I haven't noticed any CI/CD pipeline checking the Docker image. (Perhaps that should be a task in itself.)

Was the change discussed in an issue or in the forum before?

Yes: https://forum.rclone.org/t/run-docker-container-in-userspace/11734/7

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)
mateidavid added 2 commits Sep 17, 2019
- ref: https://forum.rclone.org/t/run-docker-container-in-userspace/11734/7
- enable userspace operation
- enable Docker userspace mount exposed to the host
- add more Docker image usage documentation
@ncw

This comment has been minimized.

Copy link
Collaborator

commented Sep 17, 2019

That looks really good thank you and excellent documentation :-)

I'll merge that now!

@ncw ncw merged commit ab89e93 into rclone:master Sep 17, 2019
3 of 4 checks passed
3 of 4 checks passed
rclone.rclone Build #20190917.1 failed
Details
GolangCI No issues found!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mateidavid

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

Thanks.

Just a quick note- I realized there's a typo in the doc file: It should read:

You need to mount the host rclone config dir at /config/rclone.

instead of:

You need to mount the host rclone config dir at /config.

However, this is seen in the example commands right below.

I'm not sure if this warrants another commit, let me know if you think so.

@ncw

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2019

I'm not sure if this warrants another commit, let me know if you think so.

It is probably worth fixing up so if you want to send another PR it will be easy to merge!

@mateidavid mateidavid referenced this pull request Sep 18, 2019
5 of 5 tasks complete
@jeroenvdheuvel

This comment has been minimized.

Copy link

commented Oct 8, 2019

@ncw can this change be merged into the v1.49-fixes branch (or have this fix in another stable version)? I'm currently using the beta image because there's no stable version with this fix.

The fix only breaks BC for people that use docker. However, it allows the broken experience to work when you're executing it via a non-root user.

@ncw

This comment has been minimized.

Copy link
Collaborator

commented Oct 8, 2019

I'm planning on releasing v1.50 in the next week or two so I'd rather wait until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.