smb: add support for SMB #6448
Merged
smb: add support for SMB #6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! 👍 Maybe we should cross-link its doc page with the local backend, which today mentions:
I assume this SMB backend will overlap with that? And then what are the (dis-)advantages with either of them? Edit: Of course, the above relates to Windows-specific local backend. |
I guess so
The benefit for this is that it works without Windows or GVFS installation, even on embedded devices or CIs |
albertony
reviewed
Sep 18, 2022
|
This is a great piece of work - thank you :-) How are the integration tests looking? Do you think you could make a docker image so we can run integration tests automatically, something like https://github.com/rclone/rclone/blob/master/fstest/testserver/init.d/TestFTPProftpd ? Maybe using something like this? https://hub.docker.com/r/dperson/samba |
Everything is okay
I think that docker image works. The tests above are carried out by using the servers with smbd |
|
Nice! Do you want to add the docker image to I can do that if you want. Other than that, do you think the code is ready to merge? |
Can you please make one for it? I'm not familiar with how these tests are done
Yes |
|
I've added a commit which fixes these
I've added another commit which adds a docker command which runs a local smb server in a docker container. This will run if you do I added a 3rd commit to fix the lint problem. All the tests pass - super job - well done :-) I'll give the code a review now. |
ncw
reviewed
Sep 20, 2022
- you can type an empty password - clarify the situation that filename turns into 8.3
tooptoop4
approved these changes
Sep 22, 2022
Lesmiscore
commented
Sep 25, 2022
|
@ncw ping |
|
@ncw Ping again |
ncw
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
I think this is looking really good - all the tests pass.
The docs could do with filling out a bit (@albertony maybe you could help here?) but we can do that after merge.
Thank you for a great feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Add the SMB backend
Was the change discussed in an issue or in the forum before?
Closes #2042
Checklist