New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smb: add support for SMB #6448
smb: add support for SMB #6448
Conversation
Interesting! 👍 Maybe we should cross-link its doc page with the local backend, which today mentions:
I assume this SMB backend will overlap with that? And then what are the (dis-)advantages with either of them? Edit: Of course, the above relates to Windows-specific local backend. |
I guess so
The benefit for this is that it works without Windows or GVFS installation, even on embedded devices or CIs |
This is a great piece of work - thank you :-) How are the integration tests looking? Do you think you could make a docker image so we can run integration tests automatically, something like https://github.com/rclone/rclone/blob/master/fstest/testserver/init.d/TestFTPProftpd ? Maybe using something like this? https://hub.docker.com/r/dperson/samba |
Everything is okay
I think that docker image works. The tests above are carried out by using the servers with smbd |
Nice! Do you want to add the docker image to I can do that if you want. Other than that, do you think the code is ready to merge? |
Can you please make one for it? I'm not familiar with how these tests are done
Yes |
I've added a commit which fixes these
I've added another commit which adds a docker command which runs a local smb server in a docker container. This will run if you do I added a 3rd commit to fix the lint problem. All the tests pass - super job - well done :-) I'll give the code a review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great 👍
I put some minor comments inline.
- you can type an empty password - clarify the situation that filename turns into 8.3
@ncw ping |
@ncw Ping again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking really good - all the tests pass.
The docs could do with filling out a bit (@albertony maybe you could help here?) but we can do that after merge.
Thank you for a great feature
What is the purpose of this change?
Add the SMB backend
Was the change discussed in an issue or in the forum before?
Closes #2042
Checklist