Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tensorflow be optional to allow using tensorflow-gpu #29

Merged
merged 1 commit into from Feb 6, 2018
Merged

Make tensorflow be optional to allow using tensorflow-gpu #29

merged 1 commit into from Feb 6, 2018

Conversation

tiangolo
Copy link
Contributor

@tiangolo tiangolo commented Feb 6, 2018

As tensorflow is listed as a dependency of this project, if tensorflow-gpu (the GPU / Nvidia version) is installed, it will be overwritten and not used. It makes this package incompatible with GPUs and only work in CPU.

The change is based on one of the possible workarounds suggested in a related TensorFlow issue: tensorflow/tensorflow#7166

The change is only the section with:

 extras_require={
        "tf": ["tensorflow"],
        "tf_gpu": ["tensorflow-gpu"],
    })

The rest is just auto-formatting (yapf).

@rcmalli
Copy link
Owner

rcmalli commented Feb 6, 2018

Thanks, it seems a better way to handle tensorflow dependency.

@rcmalli rcmalli merged commit e8b9436 into rcmalli:master Feb 6, 2018
@tiangolo tiangolo deleted the allow-tensorflow-gpu branch February 7, 2018 09:32
@tiangolo
Copy link
Contributor Author

tiangolo commented Feb 7, 2018

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants