Fixed #issue-70 related to get_json_object functionality for hive-serde #71

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@snehalNagmote

This issue is related to get_json_object does not work with hive serde on Json String unless one defines it as struct.
#70

@snehalNagmote

This comment has been minimized.

Show comment
Hide comment
@snehalNagmote

snehalNagmote May 28, 2014

I fixed this by adding String object inspector that would handle Json and tested it , it works, Look forward to your review and comments .

I fixed this by adding String object inspector that would handle Json and tested it , it works, Look forward to your review and comments .

@ashokkumar-dhanavel

This comment has been minimized.

Show comment
Hide comment
@ashokkumar-dhanavel

ashokkumar-dhanavel Sep 11, 2014

I have recently reported a similar issue with get_json_object,

#82

then I merged with develop branch with pull request and its working perfectly. Is this eventually going to merge with developing branch ?

I have recently reported a similar issue with get_json_object,

#82

then I merged with develop branch with pull request and its working perfectly. Is this eventually going to merge with developing branch ?

@rcongiu

This comment has been minimized.

Show comment
Hide comment
@rcongiu

rcongiu Sep 11, 2014

Owner

This pull request is mostly formatting changes and can't be merged automatically.
When a pull request is like that, it's much harder to review. Please do keep in mind I work on this on my spare time. Can you please submit a pull request or a diff for just the relevant change ?

Owner

rcongiu commented Sep 11, 2014

This pull request is mostly formatting changes and can't be merged automatically.
When a pull request is like that, it's much harder to review. Please do keep in mind I work on this on my spare time. Can you please submit a pull request or a diff for just the relevant change ?

@snehalNagmote

This comment has been minimized.

Show comment
Hide comment
@snehalNagmote

snehalNagmote Sep 11, 2014

Apologies for inconvenience . My IDE messed up with formatting , but I did
revert back those formatting changes after I created pull request . If you
look into files changed , you should be able to figure out the relevant
changes/diff , Or I would submit new pull request by tomorrow

Let me know ,

Thanks,
Snehal

On 10 September 2014 23:29, Roberto Congiu notifications@github.com wrote:

This pull request is mostly formatting changes and can't be merged
automatically.
When a pull request is like that, it's much harder to review. Please do
keep in mind I work on this on my spare time. Can you please submit a pull
request or a diff for just the relevant change ?


Reply to this email directly or view it on GitHub
#71 (comment)
.

Apologies for inconvenience . My IDE messed up with formatting , but I did
revert back those formatting changes after I created pull request . If you
look into files changed , you should be able to figure out the relevant
changes/diff , Or I would submit new pull request by tomorrow

Let me know ,

Thanks,
Snehal

On 10 September 2014 23:29, Roberto Congiu notifications@github.com wrote:

This pull request is mostly formatting changes and can't be merged
automatically.
When a pull request is like that, it's much harder to review. Please do
keep in mind I work on this on my spare time. Can you please submit a pull
request or a diff for just the relevant change ?


Reply to this email directly or view it on GitHub
#71 (comment)
.

wmoss added a commit to wmoss/Hive-JSON-Serde that referenced this pull request Sep 18, 2014

Fix for #issue-70 related to get_json_object
This is a reworking of 
rcongiu#71 to update it to the
new directory structure in 1.3

wmoss added a commit to wmoss/Hive-JSON-Serde that referenced this pull request Sep 18, 2014

Fix for #issue-70 related to get_json_object
This is a reworking of
rcongiu#71 to update it to the
new directory structure in 1.3

wmoss added a commit to wmoss/Hive-JSON-Serde that referenced this pull request Sep 19, 2014

Fix for #issue-70 related to get_json_object
This is a reworking of
rcongiu#71 to update it to the
new directory structure in 1.3
@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Apr 2, 2017

Contributor

This should be closed via #90.

Contributor

dblock commented Apr 2, 2017

This should be closed via #90.

YijiaJin pushed a commit to YijiaJin/Hive-JSON-Serde that referenced this pull request Jun 20, 2017

r - Fix for #issue-70 related to get_json_object
This is a reworking of
rcongiu#71 to update it to the
new directory structure in 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment