Skip to content

Conversation

@iLFTH
Copy link
Contributor

@iLFTH iLFTH commented Aug 11, 2020

Added simple description for Zircon system calls.
Cargo doc updated :zCore/target/doc/zircon_syscall/struct.Syscall.html

@coveralls
Copy link

coveralls commented Aug 11, 2020

Pull Request Test Coverage Report for Build 203966780

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 71 (0.0%) changed or added relevant lines in 17 files are covered.
  • 599 unchanged lines in 27 files lost coverage.
  • Overall coverage increased (+0.3%) to 41.977%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/debug.rs 0 1 0.0%
zircon-syscall/src/system.rs 0 1 0.0%
zircon-syscall/src/channel.rs 0 2 0.0%
zircon-syscall/src/exception.rs 0 2 0.0%
zircon-syscall/src/vmo.rs 0 2 0.0%
zircon-syscall/src/cprng.rs 0 3 0.0%
zircon-syscall/src/socket.rs 0 3 0.0%
zircon-syscall/src/handle.rs 0 4 0.0%
zircon-syscall/src/hypervisor.rs 0 4 0.0%
zircon-syscall/src/object.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
linux-loader/src/main.rs 1 96.77%
zircon-syscall/src/resource.rs 1 0.0%
linux-syscall/src/lib.rs 2 42.25%
zircon-syscall/src/port.rs 2 0.0%
zircon-syscall/src/debuglog.rs 3 0.0%
zircon-syscall/src/fifo.rs 3 0.0%
zircon-syscall/src/system.rs 4 0.0%
zircon-syscall/src/exception.rs 5 0.0%
zircon-syscall/src/debug.rs 6 0.0%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/bitflags-1.2.1/src/lib.rs 7 43.27%
Totals Coverage Status
Change from base Build 202563232: 0.3%
Covered Lines: 5546
Relevant Lines: 13212

💛 - Coveralls

@iLFTH iLFTH closed this Aug 11, 2020
@wangrunji0408
Copy link
Member

Why closed?

@iLFTH
Copy link
Contributor Author

iLFTH commented Aug 11, 2020

Sorry, the automatic check didn't pass. Because I haven't run “cargo fmt” to format the code before this “pull request”. I will resubmit it tomorrow.

@wangrunji0408
Copy link
Member

You can commit to and push this branch directly. The PR will trace the update.

@wangrunji0408 wangrunji0408 reopened this Aug 11, 2020
@wangrunji0408 wangrunji0408 added the documentation Improvements or additions to documentation label Aug 11, 2020
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@wangrunji0408 wangrunji0408 merged commit a0cc7dd into rcore-os:master Aug 12, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Preliminary code comments have been added for Zircon-syscalls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants