New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation in the Linear Regression Example #22

Merged
merged 3 commits into from Aug 9, 2017

Conversation

Projects
None yet
3 participants
@LeahPrice
Collaborator

LeahPrice commented Aug 8, 2017

Adapting the temperature schedule, number of MCMC repeats and the random walk covariance matrices in the likelihood annealing SMC implementation of the simple linear regression example.

Also correcting a couple of issues with calls to abs() from a previous pull request.

LeahPrice added some commits Aug 8, 2017

Correcting absolute value
Using std::abs() for double type input arguments instead of abs()
Adaptation in Linear Regression Example
Adapting the temperature schedule, number of MCMC repeats and random walk covariance matrices in the likelihood annealing SMC implementation of this example.
@adamjohansen

Looks good to me... I have one trivial quibble about whitespace and one genuine query about the best way to deal with binding of lazy loaded data, but nothing of any substance.

Show outdated Hide outdated R/LinRegLA_adapt.R
}
return FALSE;
}
}

This comment has been minimized.

@adamjohansen

adamjohansen Aug 8, 2017

Collaborator

Missing newline...

@adamjohansen

adamjohansen Aug 8, 2017

Collaborator

Missing newline...

This comment has been minimized.

@LeahPrice

LeahPrice Aug 8, 2017

Collaborator

Thanks. I've fixed this up now.

@LeahPrice

LeahPrice Aug 8, 2017

Collaborator

Thanks. I've fixed this up now.

@adamjohansen

Great, thanks @LeahPrice.

@eddelbuettel eddelbuettel merged commit a865312 into rcppsmc:master Aug 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment