-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor correction to documentation #3
Conversation
Correcting the description of GetParticleWeight().
ChangeLog
Outdated
|
||
* inst/include/sampler.h: Correcting the description of GetParticleWeight(). | ||
|
||
2017-07-24 Leah South <leah.south@hdr.qut.edu.au> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitwick: when one has two entries with the same data and author one tends to merge those.
But thanks for keeping up with ChangeLog!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry are you referring to merging the entries in the ChangeLog or another type of merge? I just did a commit to remove the unnecessary ChangeLog entry.
@LeahPrice You removed the entire ChangeLog entry. That is not what I suggested. I suggested to regroup all entries having the same date under the same date. Anyway.... |
@eddelbuettel Okay, thanks for clarifying that. When you said the same data and author, I misinterpreted it as the same author and general theme of the update. I removed the extra entry because it was just an error introduced in the previous change. I've fixed this up now and combined into one. |
Merged. I still think you need entries for your name and email in edd@brad:~$ head -3 .gitconfig
[user]
name = Dirk Eddelbuettel
email = edd@debian.org
edd@brad:~$ so that your commits are market as yours. Just about every git beginner's tutorial mentions this, you may have skipped it. Might be worth adding (though again I have no idea where to do this on Windows, but lots of other users seem to manage....) |
Thanks @eddelbuettel for picking up that it didn't work. Could you please let me know where you found that quoted log that said |
|
Correcting the description of GetParticleWeight().