Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upuse std::pow instead of pow to fix solaris build #42
Conversation
|
Thanks Dirk, this looks pretty uncontroversial to me... fingers crossed that it resolves the ambiguity. |
|
I tried it at r-hub in order to use solaris, but the builder had a network issue. Log is here. |
|
Wow. @gaborcsardi already fixed the rhub issue I filed and I just checked the package with this PR there. No issue. (Now, I am not fully sure that it is the identical setup but probably close enough. |
|
Hah! When I check the master branch (without the So PR is good. |
|
Excellent... any reason not to merge? |
|
Why the |
|
@adamjohansen No, I'll do it later. |
We seem to fail to build on Slowlaris as seen here.
This may help.