New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std::pow instead of pow to fix solaris build #42

Merged
merged 1 commit into from Mar 18, 2018

Conversation

Projects
None yet
3 participants
@eddelbuettel
Collaborator

eddelbuettel commented Mar 17, 2018

We seem to fail to build on Slowlaris as seen here.

This may help.

@adamjohansen

This comment has been minimized.

Collaborator

adamjohansen commented Mar 17, 2018

Thanks Dirk, this looks pretty uncontroversial to me... fingers crossed that it resolves the ambiguity.

@eddelbuettel

This comment has been minimized.

Collaborator

eddelbuettel commented Mar 17, 2018

I tried it at r-hub in order to use solaris, but the builder had a network issue. Log is here.

@eddelbuettel

This comment has been minimized.

Collaborator

eddelbuettel commented Mar 17, 2018

Wow. @gaborcsardi already fixed the rhub issue I filed and I just checked the package with this PR there. No issue. (Now, I am not fully sure that it is the identical setup but probably close enough.

@eddelbuettel

This comment has been minimized.

Collaborator

eddelbuettel commented Mar 17, 2018

Hah! When I check the master branch (without the std::pow() change) it does indeed break.

So PR is good.

@adamjohansen

This comment has been minimized.

Collaborator

adamjohansen commented Mar 17, 2018

Excellent... any reason not to merge?

@tibi77

This comment has been minimized.

Contributor

tibi77 commented Mar 18, 2018

Why the pow from src/blockpfgaussianopt.cpp is not changed? Is there a reason that I am missing? (Asking from a consistency point of view).

@eddelbuettel

This comment has been minimized.

Collaborator

eddelbuettel commented Mar 18, 2018

@adamjohansen No, I'll do it later.
@tibi77 You can comment on the actual line. Some remain because they are in arma::pow(); the confusion (for the Solaris compiler) arose over std::pow()

@eddelbuettel eddelbuettel merged commit 3211f50 into master Mar 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the feature/more_std branch Mar 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment