Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some added CRAN polish and updates (closes #48) #49

Merged
merged 3 commits into from Aug 30, 2020

Conversation

@eddelbuettel
Copy link
Collaborator

@eddelbuettel eddelbuettel commented Aug 29, 2020

The changes are split over three commits where

  1. addresses the initial complaint from the email quoted in #48
  2. addresses what comes up these days in R CMD check --as-cran, it is all minor but happy to discuss one by one
  3. just rolls the version to an intermediate minor to create a different .tar.gz

Let me know what you think, there is no real need for action.

@eddelbuettel eddelbuettel requested review from adamjohansen and LeahPrice Aug 29, 2020
Copy link
Collaborator

@adamjohansen adamjohansen left a comment

Thanks for taking care of this, @eddelbuettel , it all looks good to me.

@eddelbuettel eddelbuettel merged commit e9fc887 into master Aug 30, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel
Copy link
Collaborator Author

@eddelbuettel eddelbuettel commented Aug 30, 2020

I'll slap a 0.2.2 label on it and ship it to CRAN to satisfy their request quoted in #48.

@LeahPrice
Copy link
Collaborator

@LeahPrice LeahPrice commented Aug 30, 2020

Thanks Dirk! I hope you're both well. Sorry for the slow reply.

@eddelbuettel eddelbuettel deleted the features/cran_polish branch Aug 30, 2020
@eddelbuettel
Copy link
Collaborator Author

@eddelbuettel eddelbuettel commented Aug 30, 2020

No worries. Time zones and all, plus the weekend (which is simply a good time for me to do some open source work with a fresh coffee.)

Release 0.2.2 just hit CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.