-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mmtf::encodeToMap #12
Conversation
Thanks for the extra convenience function. Looks very useful and I just changed some style issues (and fixed an old bug). It triggers a semi-philosophical question though: Shall we drop C++-03 support? This would enable the use of "auto" everywhere but we would have to adapt the README. So far everything apart from unit tests could compile and run without a C++-11 compatible compiler. Now with this change, we would require at least partial C++-11 support (namely the |
Sorry for not paying attention that C++03 is the current supported standard. Removing the I'd also be fine with dropping C++-03 support. Regarding style issues: Do you use clang-format? If yes, can you add your |
I never used clang-format so I don't know much about it. Generally, I never looked into strictly defining a coding style. I prefer to just keep files consistent, but I never liked to be super strict there. Not sure how well high-level concepts like separating signatures from implementations and documenting public functions can be captured by a coding style. These are the things I care more about and I don't want to get lost into discussions on where to put brackets and line continuations. |
thanks, sounds good. I wasn't suggesting to enforce a style, I was just wondering if there is something that could help streamline pull requests. And yes, clang-format is only about whitespace, it won't reorganize your signatures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me and even work with C++-03 now, so we can keep the README as is.
mmtf::encodeToMap
is exactly likemmtf::encodeToStream
, but without the final call tomsgpack::pack
. This allows an application to add custom fields to the map before it's packed.Example which adds PyMOL's color and representation as custom fields: