Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixelated/dithered widgets issue. #100

Closed
ghost opened this issue Jul 4, 2023 · 7 comments
Closed

Pixelated/dithered widgets issue. #100

ghost opened this issue Jul 4, 2023 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jul 4, 2023

Hey man! Love the theme.
Decided to open an issue because I had to rollback the spritesheets.
I don't think you noticed, but the new version that you uploaded looks compressed or messed up.
Take a look.

image
This is the new spritesheet.
image
This is the old one.

There hasn't been an issue about it yet, so I decided to write this, hoping you could fix it so no one will face this issue :)

@rdbende
Copy link
Owner

rdbende commented Jul 4, 2023

Shit. I published 3 bugfix releases before I came abroad, but I forgot to actually try them out.

Thank you for noticing this! Hopefully I can fix it from my phone, or else I'd need someone to fix it.

@ghost
Copy link
Author

ghost commented Jul 4, 2023

I understand man, working abroad is a mess! I'm glad I could help you notice.

@rdbende rdbende mentioned this issue Jul 4, 2023
@rdbende
Copy link
Owner

rdbende commented Jul 4, 2023

I'd be grateful, if somebody could help me with this, because developing from a phone is a nightmare. I can't figure out what's wrong, and what might cause the issue.

How to do it:

  • git clone the repo
  • npm install inside src/
  • Experiment with some stuff (might even change versions in packages.json and the reinstall packages.
  • node spritesheet_generator.js
  • See if pixelatedness and ditheredness gets fixed.

@rdbende rdbende added bug Something isn't working help wanted Extra attention is needed labels Jul 4, 2023
@ghost
Copy link
Author

ghost commented Jul 4, 2023

Oh it's not the spritesheet generator, it's the image itself!
I myself have been able to fix the issue by looking at the commit logs.

cb2b3a7

From there, I just downloaded the originals & replaced them inside the sv-ttk/theme folder
I believe that the issue has nothing to do with the spritesheet generator as what appears look more like compression artifacts than anything.
Worst case scenario, if the spritesheet generator is involved, maybe you could just roll it back to it's first version. That should do the trick

@rdbende
Copy link
Owner

rdbende commented Jul 4, 2023

Sooo. Turns out I actually fixed it, just caching got in the way, and the preview was outdated. Will publish a release ASAP.

@rdbende
Copy link
Owner

rdbende commented Jul 4, 2023

Ok, I managed to fix it.

@rdbende rdbende closed this as completed Jul 4, 2023
@rdbende
Copy link
Owner

rdbende commented Jul 4, 2023

Thankfully a lotta stuff is automated here, which made fixing it from a phone way easier. I don't know my Pypi password anyway :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant