Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MsgPack deprecation warning. #126

Merged
merged 2 commits into from
Oct 12, 2019
Merged

Fix MsgPack deprecation warning. #126

merged 2 commits into from
Oct 12, 2019

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Oct 7, 2019

Fixes the deprecation warning

┌ Warning: `Ext(type, data)` is deprecated, use `MsgPack.Extension(type, data)` instead.
│   caller = pack(::Base.GenericIOBuffer{Array{UInt8,1}}, ::MeshCat.PackedVector{Float32}) at msgpack.jl:7
└ @ MeshCat ~/.julia/packages/MeshCat/J3ExE/src/msgpack.jl:7

introduced in version 1.0.0 of MsgPack.

rdeits
rdeits reviewed Oct 8, 2019
View reviewed changes
Copy link
Owner

@rdeits rdeits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just one minor comment on MsgPack versioning.

Project.toml
@@ -29,6 +29,7 @@ AssetRegistry = "0.1"
Cassette = "≥ 0.2.5"
GeometryTypes = "0.6, 0.7"
JSExpr = "0.3, 0.5"
MsgPack = "≥ 1.0.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do MsgPack = "1" so we don't assume compatibility with MsgPack 2.0 and above.

@rdeits rdeits mentioned this pull request Oct 11, 2019
Merged
@rdeits rdeits merged commit a69e879 into master Oct 12, 2019
@tkoolen tkoolen deleted the tk/msgpack-update branch October 12, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdeits rdeits rdeits left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkoolen @rdeits