Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding support for non-square images #21

Merged
merged 6 commits into from Jul 18, 2014

Conversation

Projects
None yet
2 participants
Contributor

jimfleming commented Jul 18, 2014

Makes both width and height parameters optional. If you provide a width (or height) Thor will infer an aspect ratio from the first image layer and compute the other dimension from that aspect ratio. You can provide neither and it'll just use the first images dimensions.

Also refactoring some of the image processing into another class.

@jnorton001 jnorton001 added a commit that referenced this pull request Jul 18, 2014

@jnorton001 jnorton001 Merge pull request #21 from jimfleming/nonsquare
Adding support for non-square images
aedc29e

@jnorton001 jnorton001 merged commit aedc29e into rdio:master Jul 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment