Skip to content

RDKEMW-8133: Optional param name for voiceSessionRequest #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2025
Merged

RDKEMW-8133: Optional param name for voiceSessionRequest #108

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79c8123
RDKEMW-8133: Optional param name for voiceSessionRequest
klu339 Sep 11, 2025
57d8b78
RDKEMW-8133: Optional param name for voiceSessionRequest
klu339 Sep 12, 2025
23bee2c
RDKEMW-8133: Optional param name for voiceSessionRequest
klu339 Sep 17, 2025
dcfefdf
RDKEMW-8133: Optional param name for voiceSessionRequest
klu339 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/voice/ipc/ctrlm_voice_ipc_iarm_thunder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,8 +653,9 @@ IARM_Result_t ctrlm_voice_ipc_iarm_thunder_t::voice_session_request(void *data)

json_t *obj_type = json_object_get(obj, "type");
std::string str_type = "";
std::string str_transcription = "";
std::string str_audio_file = "";
std::string str_transcription = "";
std::string str_audio_file = "";
std::string str_name_of_source = "APPLICATION";
int fd = -1;
if(obj_type == NULL || !json_is_string(obj_type)) {
XLOGD_ERROR("request type parameter not present");
Expand Down Expand Up @@ -776,14 +777,22 @@ IARM_Result_t ctrlm_voice_ipc_iarm_thunder_t::voice_session_request(void *data)
}
}
}
json_t *obj_name_of_source = json_object_get(obj, "name");
if(obj_name_of_source != NULL) {
if(!json_is_string(obj_name_of_source)) {
XLOGD_WARN("name parameter is not a string - ignoring");
} else {
str_name_of_source = std::string(json_string_value(obj_name_of_source));
}
}
}
}
}

if (true == result) {
ctrlm_voice_session_response_status_t voice_status = voice_obj->voice_session_req(
CTRLM_MAIN_NETWORK_ID_INVALID, CTRLM_MAIN_CONTROLLER_ID_INVALID,
request_config.device, request_config.format, NULL, "APPLICATION", "0.0.0.0", "0.0.0.0", 0.0,
request_config.device, request_config.format, NULL, str_name_of_source.c_str(), "0.0.0.0", "0.0.0.0", 0.0,
false, NULL, NULL, NULL, (fd >= 0) ? true : false, true, str_transcription.empty() ? NULL : str_transcription.c_str(), str_audio_file.empty() ? NULL : str_audio_file.c_str(), &request_uuid, request_config.low_latency, request_config.low_cpu_util, fd);
if (voice_status != VOICE_SESSION_RESPONSE_AVAILABLE &&
voice_status != VOICE_SESSION_RESPONSE_AVAILABLE_PAR_VOICE) {
Expand Down