Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang++ warning in AtomPairs.cpp #145

Closed
greglandrum opened this issue Nov 5, 2013 · 1 comment
Closed

Fix clang++ warning in AtomPairs.cpp #145

greglandrum opened this issue Nov 5, 2013 · 1 comment
Assignees
Milestone

Comments

@greglandrum
Copy link
Member

/scratch/RDKit_git/Code/GraphMol/Fingerprints/AtomPairs.cpp:448:78: warning: operator '<<' has lower precedence than '+';
'+' will be evaluated first [-Wshift-op-parentheses]
atomCodes.push_back(((_atomInvariants)[(_atomItI)->getIdx()])<<1 + 1);
~~~~^~~
/scratch/RDKit_git/Code/GraphMol/Fingerprints/AtomPairs.cpp:448:78: note: place parentheses around the '+' expression to
silence this warning
atomCodes.push_back(((*atomInvariants)[(*atomItI)->getIdx()])<<1 + 1);

@ghost ghost assigned greglandrum Nov 5, 2013
@greglandrum
Copy link
Member Author

Fixed with 38ca41c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant