Support Python 3.11 #5994
Merged
Support Python 3.11 #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bp-kelley : this is an alternate approach to handle the deprecation of the extra argument to |
|
I’ll be able to take a look this weekend. If it’s better Han the previous random fix, I’m all for it. |
bp-kelley
reviewed
Jan 23, 2023
bp-kelley
reviewed
Jan 23, 2023
| @@ -18,3 +17,30 @@ | |||
| random = _random.random | |||
| randrange = _random.randrange | |||
| seed = _random.seed | |||
|
|
|||
| if sys.hexversion >= 0x30b0000: | |||
|
LGTM |
greglandrum
added a commit
that referenced
this pull request
Feb 23, 2023
* remove some more deprecated numpy stuff * workaround for changes to random.shuffle in python 3.11 * fix pickling of rdkit mols in python 3.11 * add py311 build to CI * update py311 CI * remove qt for py311 for the moment * only use the new code with pyversion >=3.11 * use the new logic for all pickle_suites * need to work with older py too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required minor changes to the way pickling is handled and a switch away from using
random.shufflewith therandomkeyword.Also adds a CI build for py 3.11
Fixes #5911