Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements #1

Merged
merged 15 commits into from Apr 29, 2018

Conversation

Projects
None yet
2 participants
@roks0n
Copy link
Contributor

roks0n commented Apr 19, 2018

Changes:

  • Fix passing variables. Variables in single-quotes are not evaluated, have to use double quotes.
  • add nodes.txt, secret.txt to gitignore
  • change readme
  • modify ark_start(): I assumes that a person would only run ark-node using forever that's why I stopall and afterwords run a new forever process for ark-node. I mainly did this, because it occurs that I had 2 ark-node processes running at some points which got started by failover. After changing code I haven't noticed the issue again.
  • fix block_height() to pass variables correctly (see first point)
  • new variables (network_port, db, ark_path)
  • make it easier to switch between devnet/mainnet via config

QA:
I've already tested some of this points, just want to do it again with all the fresh code in the branch. :)

  • restart forging server, see if relay will start forging
  • restart both servers, see if one becomes a relay and another one forging -> missed 3 blocks, it took nodes a while to rebuild to the latest block, this could probably be improved
  • on one node, stop the process and check if failover will start it
  • shut down forging node (so that ssh raises connection error) and failover should make relay a forging node (this is currently not the case, because an error restarts the script) -> this worked like a charm
  • switching nodes works as expected
  • restart a server, wait if failover will start the ark-node on it

@reConNico reConNico self-requested a review Apr 19, 2018

@reConNico reConNico self-assigned this Apr 19, 2018

@reConNico reConNico added this to the 1.1.0 milestone Apr 19, 2018

@roks0n

This comment has been minimized.

Copy link
Contributor Author

roks0n commented Apr 19, 2018

Extra todo nodes:

  • Reduce timeout when ssh-ing node to 10s (eg. ssh -o ConnectTimeout=10 <hostName>) now it seems it tries to make connections for much longer
@roks0n

This comment has been minimized.

Copy link
Contributor Author

roks0n commented Apr 29, 2018

@reConNico let me know if you have any questions/concerns or if you'd like me to change anything. ;)

@reConNico
Copy link
Owner

reConNico left a comment

I like it. Thanks a lot @roks0n!

@reConNico reConNico merged commit d643dc1 into reConNico:master Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.