Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set modules option of es2015 preset to false #15

Merged
merged 1 commit into from Feb 9, 2019

Conversation

@cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Feb 6, 2019

Thanks to @alandipert for suggesting this change. The motivation is to suppress the "use strict" output which makes ramnathv/htmlwidgets#326 an easier problem to solve.

I'm sure there's an argument to be had for wanting to "use strict", so perhaps we should consider adding an argument to control this in babel_transform()?

@timelyportfolio timelyportfolio merged commit 6d00dd2 into react-R:master Feb 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@timelyportfolio
Copy link
Collaborator

@timelyportfolio timelyportfolio commented Feb 9, 2019

@cpsievert thanks so much, this is great. I'm excited about your work on ramnathv/htmlwidgets#329.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.