New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation requires lodash, cross-env to be installed ahead of time #1836

Closed
relwell opened this Issue Jun 29, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@relwell

relwell commented Jun 29, 2017

Issue Type

Description

If you don't have lodash or cross-env installed before running npm run setup or installed globally, then the project will delete the setup script, but will not complete setup. This puts the project in a state where you need to re-clone in order to fully set up the app.

Steps to reproduce

Run npm run setup without lodash globally installed.

Versions

  • React-Boilerplate (see package.json): head of master and most stable release
  • Node/NPM: 8.0
  • Browser: N/A

@relwell relwell changed the title from Installation requires lodash ahead of time to Installation requires lodash, cross-env to be installed ahead of time Jun 29, 2017

@relwell

This comment has been minimized.

Show comment
Hide comment
@relwell

relwell Jun 29, 2017

It actually looks like what may be happening is that running npm run setup does not install any dependencies like it claims it should be. Note that I'm running npm 5.4.0.

relwell commented Jun 29, 2017

It actually looks like what may be happening is that running npm run setup does not install any dependencies like it claims it should be. Note that I'm running npm 5.4.0.

@derick-schoonbee

This comment has been minimized.

Show comment
Hide comment
@derick-schoonbee

derick-schoonbee Jul 8, 2017

I know that in npmcheckversion.js you check for the latest verions. But it would be nice for a beginner (like me) to know which version of node (+npm) is supported. For example do you support lts/boron (v6.11.0) ?

derick-schoonbee commented Jul 8, 2017

I know that in npmcheckversion.js you check for the latest verions. But it would be nice for a beginner (like me) to know which version of node (+npm) is supported. For example do you support lts/boron (v6.11.0) ?

@smeyfroi

This comment has been minimized.

Show comment
Hide comment
@smeyfroi

smeyfroi Nov 14, 2017

For me, with a brand new clone of this project, using these versions in a docker container:

# npm --version
4.0.5
# node --version
v7.4.0

I found that npm run setup failed (deleting internals/scripts/setup.js) until I did this:

# npm install -g lodash cross-env
/usr/local/bin/cross-env-shell -> /usr/local/lib/node_modules/cross-env/dist/bin/cross-env-shell.js
/usr/local/bin/cross-env -> /usr/local/lib/node_modules/cross-env/dist/bin/cross-env.js
/usr/local/lib
├─┬ cross-env@5.1.1
│ ├─┬ cross-spawn@5.1.0
│ │ ├─┬ lru-cache@4.1.1
│ │ │ ├── pseudomap@1.0.2
│ │ │ └── yallist@2.1.2
│ │ ├─┬ shebang-command@1.2.0
│ │ │ └── shebang-regex@1.0.0
│ │ └─┬ which@1.3.0
│ │   └── isexe@2.0.0
│ └── is-windows@1.0.1
└── lodash@4.17.4

Apart from that glitch, everything is working great. :-)

smeyfroi commented Nov 14, 2017

For me, with a brand new clone of this project, using these versions in a docker container:

# npm --version
4.0.5
# node --version
v7.4.0

I found that npm run setup failed (deleting internals/scripts/setup.js) until I did this:

# npm install -g lodash cross-env
/usr/local/bin/cross-env-shell -> /usr/local/lib/node_modules/cross-env/dist/bin/cross-env-shell.js
/usr/local/bin/cross-env -> /usr/local/lib/node_modules/cross-env/dist/bin/cross-env.js
/usr/local/lib
├─┬ cross-env@5.1.1
│ ├─┬ cross-spawn@5.1.0
│ │ ├─┬ lru-cache@4.1.1
│ │ │ ├── pseudomap@1.0.2
│ │ │ └── yallist@2.1.2
│ │ ├─┬ shebang-command@1.2.0
│ │ │ └── shebang-regex@1.0.0
│ │ └─┬ which@1.3.0
│ │   └── isexe@2.0.0
│ └── is-windows@1.0.1
└── lodash@4.17.4

Apart from that glitch, everything is working great. :-)

@gretzky

This comment has been minimized.

Show comment
Hide comment
@gretzky

gretzky Dec 13, 2017

Contributor

I'm going to try and see if I can replicate this and I'll reopen if it's still not working

Contributor

gretzky commented Dec 13, 2017

I'm going to try and see if I can replicate this and I'll reopen if it's still not working

@gretzky gretzky closed this Dec 13, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot commented May 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.