/react-boilerplate

chore(setup): integrate LGTM #1258

Merged
merged 1 commit into from Nov 28, 2016

Conversation

Reviewers

@mxstbr mxstbr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Dattaya @coveralls @samit4me @mxstbr
@Dattaya
Member

Dattaya commented Nov 22, 2016 • edited

@mxstbr, first it didn't work for a non default branch like you said on gitter, then I did nothing and it started to work ✨, you can see that in my experimental repository: Dattaya/Temp#3

Also, LGTM hook appeared on branch's settings page (appeared unchecked I checked it myself):
image

#1209
@Dattaya Dattaya chore(setup): integrate LGTM

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
deploy/netlify — Deploy preview ready!
Details
fe010cd
MAINTAINERS
+chaintng
+samit4me
+amilajack
+Dattaya
@Dattaya

Dattaya Nov 22, 2016

Member

Have I missed someone?

@mxstbr

mxstbr Nov 22, 2016

Owner

I think you got them all, nice!

@coveralls

coveralls commented Nov 22, 2016 • edited

Coverage Status

Coverage remained the same at 98.77% when pulling fe010cd on Dattaya:integrate-lgtm into 6c637d5 on mxstbr:master.
@mxstbr

mxstbr approved these changes Nov 22, 2016 View changes

Awesome, let's do this! LGTM

MAINTAINERS
+chaintng
+samit4me
+amilajack
+Dattaya
@mxstbr

mxstbr Nov 22, 2016

Owner

I think you got them all, nice!

@Dattaya
Member

Dattaya commented Nov 22, 2016 • edited

Predictably, Appveyor failed due to #1246 that was fixed in dev but not in master.
@samit4me
Owner

samit4me commented Nov 26, 2016 • edited

LGTM, is this something we can merge into dev so it will be merged to master in the next release?
@mxstbr
Owner

mxstbr commented Nov 28, 2016

I think we should merge this into master, otherwise it won't be enabled until the next release

mxstbr merged commit 251c31c into react-boilerplate:master Nov 28, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

Dattaya deleted the Dattaya:integrate-lgtm branch Nov 28, 2016

@PierrickGT PierrickGT pushed a commit to PierrickGT/react-boilerplate that referenced this pull request Nov 29, 2016

@Dattaya Dattaya + Turelier Pierrick chore(setup): integrate LGTM (#1258) 451adec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment