New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #1309 by only requiring the lodash pieces in use, the overall file size required is reduced #1312

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
5 participants
@jwinn
Copy link
Collaborator

jwinn commented Dec 6, 2016

  • double-check your branch is based on dev and targets dev
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues
@gihrig

This comment has been minimized.

Copy link
Member

gihrig commented Dec 6, 2016

LGTM 💯

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 7, 2016

Coverage Status

Coverage remained the same at 98.578% when pulling 383b095 on jwinn:feature-1309 into 2e19191 on mxstbr:dev.

@Dattaya

This comment has been minimized.

Copy link
Member

Dattaya commented Dec 7, 2016

Webpack 2 is supposed to work with namespaced imports, unfortunately, people are still having trouble with it: webpack/webpack#2867. This PR reduces the size of the main chunk by about 60kB 👍 .
LGTM

@jwinn jwinn referenced this pull request Dec 8, 2016

Closed

Lodash more than 500Kb #1309

@mxstbr

This comment has been minimized.

Copy link
Member

mxstbr commented Dec 8, 2016

LGTM

@mxstbr mxstbr merged commit 365e310 into react-boilerplate:dev Dec 8, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lock

This comment has been minimized.

Copy link

lock bot commented May 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.