chore(deps): remove chai and chai-enzyme #1441
Merged
Conversation
coveralls
commented
Jan 11, 2017
•
edited
gihrig
approved these changes
Jan 11, 2017
•
edited
View changes
As commented here, I have tested these changes and all tests pass.
coveralls
commented
Jan 12, 2017
•
edited
|
I'm pushing a lot of clean up for 3.4, so merging... |
gihrig
merged commit f50e72b into react-boilerplate:dev Jan 12, 2017
2 checks passed
Dattaya
deleted the
Dattaya:remove-chai branch
Jan 12, 2017
AnhHT
added a commit
to AnhHT/react-boilerplate
that referenced
this pull request
Jan 18, 2017
|
|
AnhHT |
Merge with base (#2)
* feat(docs): Extracting packages into their own modules (#979) * fix(internals): Fix babel relative preset Fix webpack issue with relative babel preset paths: babel/babel-loader#149 * feat(docs): Add docs for extracting components Add draft version of docs describing how to extract components to their own npm packages. * feat(core): Move to Jest for testing (#980) * Add Jest collect coverage * fix(tests): set config and globals add coverage and script update coveralls script update chai to jest syntax args should return an array chore(tests): add babel-jest, tweak config chore(tests): update coverage settings feat(cov): remove untested closure chore(core): update watch script, use jest-cli fix(watch): add no-cache and watchAll flags * Remove generator test * jest-cli@16 * chore(jest): Remove rootDir * rebase against 3.3.0 * fix(commands): Fix 'npm run clean' breaking (#1185) (#1186) Added a constants.js file to templates that contains the DEFAULT_LOCALE export to be added to containers/App/constants on 'npm run clean'. * fix(example): Fix i18n button not updating (#1187) * feat(docs): Faq: staying updated with boilerplate (#1192) * fix(example): Fix console error on lang change (#1200) * fix(core): npm run generate language is not properly created. (#1199) * rerun extract-intl * add default language to language provider * feat(webpack): new query object syntax (#1198) * feat(ci): Node v7 support (#1197) * Node version support update * Update CI node versions * fix(docs): Replace start:prod with independent start:production (#1204) * fix(example): Fix default Intl polyfill language (#1208) * fix(docs): Fix typo in file name (#1211) * fix(example): Use `createStructuredSelector` instead of `createSelector` (#1212) * chore(deps): update deps roll-up Nov-12-2016 (#1225) * chore(deps): update deps roll-up Nov-19-2016 (#1252) * Prevent language duplication (#1253) * Satisfy ESLint rule: no-restricted-syntax (#1243) * feat(webpack) Add circular dependency plugin for Webpack. (#1262) * feat(webpack) Add circular dependency plugin for Webpack. This plugin detects circular dependencies and shows a warning or fails. It is less obtrusive to just show a warning. That's why it defaults to that. * small fix to webpack config * Remove webpack DedupePlugin (#1218) * Fix typo in container generator (#1242) * fix(eslint config): resolve numerous invalid lint errors seen in Atom editor (#1261) * Disable ESLint rule: no-confusing-arrow (#1238) * Fix links to styled-components doc (#1289) * Add missing document (Using Sass section CSS) to table content (#1271) * fix #1270 * add brackets to document Using Sass * Remove '#if wantCSS' from generator templates (#1260) Remove '#if wantCSS' from container generator Remove '#if wantCSS' from es6 pure generator template * feat(core): Don't import all of lodash * fix(package.json): Required npm version (#1219) * Fix wrong npm version introduced with d202b07 Commit d202b07 introduced a not existing npm version of >= 5 which does not exist. The correct npm version is checked during installation which might otherwise lead to an error. Conclusion might be that this was meant to be node >= 5 like mentioned in #1197 * Add the supported version of node * chore(deps): update deps roll-up Dec-03-2016 (#1301) * chore(deps): update deps roll-up Dec-03-2016 * fix(deps): sagas loaded twice - roll back react-router-redux 4.0.7 -> 4.0.6 * chore(test config): expand Jest moduleNameMapper key to include common file types (#1293) * chore(selectors): refactor selectors (#1205) * Improve .editorconfig, change insert_final_newline to true, add trim_trailing_whitespace (#1239) * fix(scripts): make LocaleToggle's massages compatible with `extract-intl` script (#1251) Fixes #1221 Reverts back #813 * feat(example): Extracted ReposList (#1285) * Bfix/reorder imports (#1275) * Reorder imports * Track package.json * Reorder remaining imports * Revert few changes in app/app.js * Add .ico extension to file-loader regex * Revert favicon, manifest, .htaccess imports * Revert favicon, manifest, .htaccess imports * Remove ico from image-webpack loader extensions * Move offline-plugin import to the top in templates/app.js * Match templates/app.js with app/app.js * Remove import/first from package.json * Reorder webpack alias imports * Reorder imports in internals/generators * Remove German from templates/app.js * fix(templates): use correct name of a selector (#1321) * chore(generators): clean up generator templates (#1304) Follow up to #1260 * fix(generator): #1231 'generate container' produces unnecessary return (#1327) * chore(internal): fix indentation in 'routeWithReducer' (#1329) * fix(HomePage): #1232 Saga effects should be yielded (#1328) * fix(generator): 'generate container' produces unnecessary return - better solution (#1333) * fix(generator): #1231 'generate container' produces unnecessary return * fix(generator): improved solution to 'generate container' produces unnecessary return #1327 * feat(ci): allow for linting of the templates (#1223) * feat(ci): allow for linting of the templates * Add comment at the top describing the purpose of generate-templates-for-linting.js * Use __dirname instead of process.cwd() * Update yarn.lock * Test coverage updates (#1334) * Exclude test files from test coverage * Add coverage threshold * Update css readme (#1338) * fix(generators, templates): add example app functionality into project templates and generators (#1331) * fix(generators, templates): add existing example app functionality into project templates and generators * fix(generators, templates): add existing example app functionality into project templates and generators * split messages import to avoid disabling an eslint rule * feat(server): Add host command line parameter to start (#1249) * add host parameter to logger * add host parameter to server * update docs to include host command line parameter * update host port command doc based on suggesitons * Rollback image-webpack-loader (#1342) * Remove babel-jest expicit dependency (#1345) implements #1344 * Make compatible with other babel plugins (#1355) * Remove psi and pagespeed (#1352) * removing psi, pagespeed, and doc references * remove psi from yarn.lock * Trigger full page reload when hmr fails (#1357) Fixes #1353 * refactor(server): remove console.log causing server screen clutter (#1361) * feat(example): Add route loading progress bar (#1008) * Add ProgressBar, modify App and write tests * fix eslint warnings * Prevent memory leak in App/index, Fix animation of ProgressBar, Add more tests * Add more tests for ProgressBar life cycle methods * Rename css class names, remove eslint-disable, add comments * Remove comments from ProgressBar tests * Prevent re-rendering of ProgressBar * Fix failing test * Add one more condition to complete progress * Update index.test.js Bring import order in line with #1275 * Update App/index.js * Update App/index.js * Fix re-rendering and make tests pass * Move progress route hooks out of <App />, update tests * Reset progress bar speed * Move <ProgressBar /> out of <App /> * Update tests * Move withProgressBar to components/ProgressBar * Rename withProgressBar -> index.js. * Add docs for ProgressBar working/usage * Update progress bar.md * Split ProgressBar/styles.js into two separate files * chore(package.json): update dependecy The test/build failed due to a regressed dependency. "react-addons-test-utils": "15.3.2", -> "react-addons-test-utils": "15.4.1", * feat(docs) a beginner's guide to RBP (#1366) * Create introduction.md * Update introduction.md Minor edits for grammar and structure. Overall, really really good. The hours of dedicated effort you put in will be appreciated by many to come! Very well done |
034ab9d
|
AnhHT
added a commit
to AnhHT/react-boilerplate
that referenced
this pull request
Jan 20, 2017
|
|
AnhHT |
Merge with base (#3)
* feat(docs): Extracting packages into their own modules (#979) * fix(internals): Fix babel relative preset Fix webpack issue with relative babel preset paths: babel/babel-loader#149 * feat(docs): Add docs for extracting components Add draft version of docs describing how to extract components to their own npm packages. * feat(core): Move to Jest for testing (#980) * Add Jest collect coverage * fix(tests): set config and globals add coverage and script update coveralls script update chai to jest syntax args should return an array chore(tests): add babel-jest, tweak config chore(tests): update coverage settings feat(cov): remove untested closure chore(core): update watch script, use jest-cli fix(watch): add no-cache and watchAll flags * Remove generator test * jest-cli@16 * chore(jest): Remove rootDir * rebase against 3.3.0 * fix(commands): Fix 'npm run clean' breaking (#1185) (#1186) Added a constants.js file to templates that contains the DEFAULT_LOCALE export to be added to containers/App/constants on 'npm run clean'. * fix(example): Fix i18n button not updating (#1187) * feat(docs): Faq: staying updated with boilerplate (#1192) * fix(example): Fix console error on lang change (#1200) * fix(core): npm run generate language is not properly created. (#1199) * rerun extract-intl * add default language to language provider * feat(webpack): new query object syntax (#1198) * feat(ci): Node v7 support (#1197) * Node version support update * Update CI node versions * fix(docs): Replace start:prod with independent start:production (#1204) * fix(example): Fix default Intl polyfill language (#1208) * fix(docs): Fix typo in file name (#1211) * fix(example): Use `createStructuredSelector` instead of `createSelector` (#1212) * chore(deps): update deps roll-up Nov-12-2016 (#1225) * chore(deps): update deps roll-up Nov-19-2016 (#1252) * Prevent language duplication (#1253) * Satisfy ESLint rule: no-restricted-syntax (#1243) * feat(webpack) Add circular dependency plugin for Webpack. (#1262) * feat(webpack) Add circular dependency plugin for Webpack. This plugin detects circular dependencies and shows a warning or fails. It is less obtrusive to just show a warning. That's why it defaults to that. * small fix to webpack config * Remove webpack DedupePlugin (#1218) * Fix typo in container generator (#1242) * fix(eslint config): resolve numerous invalid lint errors seen in Atom editor (#1261) * Disable ESLint rule: no-confusing-arrow (#1238) * Fix links to styled-components doc (#1289) * Add missing document (Using Sass section CSS) to table content (#1271) * fix #1270 * add brackets to document Using Sass * Remove '#if wantCSS' from generator templates (#1260) Remove '#if wantCSS' from container generator Remove '#if wantCSS' from es6 pure generator template * feat(core): Don't import all of lodash * fix(package.json): Required npm version (#1219) * Fix wrong npm version introduced with d202b07 Commit d202b07 introduced a not existing npm version of >= 5 which does not exist. The correct npm version is checked during installation which might otherwise lead to an error. Conclusion might be that this was meant to be node >= 5 like mentioned in #1197 * Add the supported version of node * chore(deps): update deps roll-up Dec-03-2016 (#1301) * chore(deps): update deps roll-up Dec-03-2016 * fix(deps): sagas loaded twice - roll back react-router-redux 4.0.7 -> 4.0.6 * chore(test config): expand Jest moduleNameMapper key to include common file types (#1293) * chore(selectors): refactor selectors (#1205) * Improve .editorconfig, change insert_final_newline to true, add trim_trailing_whitespace (#1239) * fix(scripts): make LocaleToggle's massages compatible with `extract-intl` script (#1251) Fixes #1221 Reverts back #813 * feat(example): Extracted ReposList (#1285) * Bfix/reorder imports (#1275) * Reorder imports * Track package.json * Reorder remaining imports * Revert few changes in app/app.js * Add .ico extension to file-loader regex * Revert favicon, manifest, .htaccess imports * Revert favicon, manifest, .htaccess imports * Remove ico from image-webpack loader extensions * Move offline-plugin import to the top in templates/app.js * Match templates/app.js with app/app.js * Remove import/first from package.json * Reorder webpack alias imports * Reorder imports in internals/generators * Remove German from templates/app.js * fix(templates): use correct name of a selector (#1321) * chore(generators): clean up generator templates (#1304) Follow up to #1260 * fix(generator): #1231 'generate container' produces unnecessary return (#1327) * chore(internal): fix indentation in 'routeWithReducer' (#1329) * fix(HomePage): #1232 Saga effects should be yielded (#1328) * fix(generator): 'generate container' produces unnecessary return - better solution (#1333) * fix(generator): #1231 'generate container' produces unnecessary return * fix(generator): improved solution to 'generate container' produces unnecessary return #1327 * feat(ci): allow for linting of the templates (#1223) * feat(ci): allow for linting of the templates * Add comment at the top describing the purpose of generate-templates-for-linting.js * Use __dirname instead of process.cwd() * Update yarn.lock * Test coverage updates (#1334) * Exclude test files from test coverage * Add coverage threshold * Update css readme (#1338) * fix(generators, templates): add example app functionality into project templates and generators (#1331) * fix(generators, templates): add existing example app functionality into project templates and generators * fix(generators, templates): add existing example app functionality into project templates and generators * split messages import to avoid disabling an eslint rule * feat(server): Add host command line parameter to start (#1249) * add host parameter to logger * add host parameter to server * update docs to include host command line parameter * update host port command doc based on suggesitons * Rollback image-webpack-loader (#1342) * Remove babel-jest expicit dependency (#1345) implements #1344 * Make compatible with other babel plugins (#1355) * Remove psi and pagespeed (#1352) * removing psi, pagespeed, and doc references * remove psi from yarn.lock * Trigger full page reload when hmr fails (#1357) Fixes #1353 * refactor(server): remove console.log causing server screen clutter (#1361) * feat(example): Add route loading progress bar (#1008) * Add ProgressBar, modify App and write tests * fix eslint warnings * Prevent memory leak in App/index, Fix animation of ProgressBar, Add more tests * Add more tests for ProgressBar life cycle methods * Rename css class names, remove eslint-disable, add comments * Remove comments from ProgressBar tests * Prevent re-rendering of ProgressBar * Fix failing test * Add one more condition to complete progress * Update index.test.js Bring import order in line with #1275 * Update App/index.js * Update App/index.js * Fix re-rendering and make tests pass * Move progress route hooks out of <App />, update tests * Reset progress bar speed * Move <ProgressBar /> out of <App /> * Update tests * Move withProgressBar to components/ProgressBar * Rename withProgressBar -> index.js. * Add docs for ProgressBar working/usage * Update progress bar.md * Split ProgressBar/styles.js into two separate files * chore(package.json): update dependecy The test/build failed due to a regressed dependency. "react-addons-test-utils": "15.3.2", -> "react-addons-test-utils": "15.4.1", * feat(docs) a beginner's guide to RBP (#1366) * Create introduction.md * Update introduction.md Minor edits for grammar and structure. Overall, really really good. The hours of dedicated effort you put in will be appreciated by many to come! Very well done |
e514973
|
gihrig
referenced
this pull request
Jan 30, 2017
Closed
Coverage badge shows "unknown" in README.md #1535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dattaya commentedJan 11, 2017
•
edited
React Boilerplate
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure:
devand targetsdevWe no longer use
chaiassertions. If you guys think thatchai-enzymefunctionality is going to be useful, I can addjest-enzymeinstead.I've deleted a link to chai docs from
Introduction, the testing section of the docs is mostly outdated, but it's a subject of another PR.Edit: turns out it's not outdated, I've just forgotten #1390 was merged into
3.4and notdev.