New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: V4 support #2752

Closed
wants to merge 18 commits into
base: next
from

Conversation

Projects
None yet
@jquense
Member

jquense commented Aug 11, 2017

Progress for v4 support is now tracked via github project: https://github.com/react-bootstrap/react-bootstrap/projects/1 refer to that for progress and places to help

This is very very very WIP, not likely to be merged soon. Since v4 is now in beta it seems like a good time to start exploring updates here in RB.

I’ve set up a storybook to track the components visually and confirm stuff is matching the upstream docs. Its very informal (a checkmark in the description) but Should leave us with a good sense of progress at least initially

  • buttons
  • transitions
  • dropdowns
  • cards
  • labels/badges
  • tables
  • tabs/pills
  • nav
  • navbar
    ...more things

@jquense jquense referenced this pull request Aug 11, 2017

Closed

Bootstrap 4 Roadmap #1187

@taion

This comment has been minimized.

Member

taion commented Aug 11, 2017

What do you think we should do here, BTW? Break things and support only v4, or move the v3 stuff into a subdirectory?

@jquense

This comment has been minimized.

Member

jquense commented Aug 11, 2017

I think we call v1 on what we have. e.g. one more < 1.0.0 version to collect some feedback on the panel and pagination changes and then v1

then v2 for v4. We can keep the v1 branch around for bugfixes etc, and keep pushing releases. I think it'll still be months before v4 hits stable, so i'm not super worried. And the v1 for us is really a formality, this has been a very stable package for many months now.

@leoskyrocker

This comment has been minimized.

leoskyrocker commented Aug 12, 2017

Hi,

We're currently using reactstrap in our production app.
Totally out of curiosity, do you foresee any reasons/benefits to prefer this over reactstrap in the future?

Thanks

@jquense

This comment has been minimized.

Member

jquense commented Aug 12, 2017

I'm not super familiar with that project but I can speak to what RB is good at. We care about upgrade paths and stability since maintainers all depend on this code for production use. We also care about providing good idiomatic react APIs over bootstrap as well as provide top-notch a11y defaults as well

@changLiuUNSW

This comment has been minimized.

changLiuUNSW commented Oct 31, 2017

@leoi11
The accessibility, component APIs of react-bootstrap is way way better than reactstrap

@leoskyrocker

This comment has been minimized.

leoskyrocker commented Nov 2, 2017

@changLiuUNSW Thanks for the info. Could you elaborate more on how the APIs is way better? I had a glance at the API, and they seem pretty close to each other other than some naming differences and some (doesn't seem to be a lot) extra callbacks on certain components.

@lednhatkhanh

This comment has been minimized.

lednhatkhanh commented Jan 19, 2018

V4 has been officially released today.

@gaspaio

This comment has been minimized.

gaspaio commented Feb 23, 2018

Is work on this stopped ?

jquense and others added some commits Jan 2, 2018

v4 Support: Fix Toggle Buttons (#2976)
* Rework Panel API (#1769)

* Upgrade `uncontrollable` dependency

* remove createClass in tests (#2586)

* remove createClass in tests

* fix-lint

* update changelog

* Release v0.31.0

* Add toggle button components (#2252)

I’m tried of rewriting this component all the time :P

* Update Dropdown.js (#2615)

fix typo

* switch to new one (#2621)

* Rework Panel API

* update

* fix up the branch, fix examples

* Finish tests

* Update PanelHeading.js

* prop-types clean up

* change collapsible API, finish examples and docs

* lint:

* clean up nits

* nits

* remove pagination logic (#2587)

* remove pagination logic

* Add upgrade path.

* Transition group (#2676)

* switch to react transition group

* Update Modal api

* fix tests

* bump and fix test

* Update package.json

* update wording

* preventDefault specified to work only for disabled && onSelect; it is a fix for issue #2711

* removing prevent defaults from any onSelect logic for NavItem, Panel, and PanelGroup

* adding tests for Panel and NavItem changes. testing for whether preventDefault is clicked and for whether the navbar collapses when it is clicked.

* part of the fix for #2711, removing preventDefault for onSelect. also modifying code so it only will preventDefault if element is disabled

* refactoring the fix for issue #2711

* figured this test was unnecessary. also fixed some linting errors. for #2711

* merge issues

* fix lint

* Add up-to-date Bootstrap stylesheets

* Add btn-link to storybook, precommit format

* Fix toggle buttons

* Update toggle prop on ButtonGroup

* Use npm registry
@jquense

This comment has been minimized.

Member

jquense commented Feb 26, 2018

@gaspaio work is proceeding as folks have time to work on it. If you or anyone else would like to see a faster pace please jump in. We would welcome the help!

jquense added some commits Mar 3, 2018

jquense added some commits Mar 5, 2018

@jquense

This comment has been minimized.

Member

jquense commented Mar 5, 2018

ya'll i'm going to close this PR and jsut make this the "base" branch for individual PR's adding support, Track the project, and individual issues for v4 progress

@jquense jquense closed this Mar 5, 2018

@wolfgangmeyers

This comment has been minimized.

wolfgangmeyers commented Mar 14, 2018

https://react-bootstrap.github.io/ still refers to this PR

@makhnatkin

This comment has been minimized.

makhnatkin commented Apr 3, 2018

@jquense Hello!
Could you imagine how long it will take the transition to Bootstrap 4? We're using your project, but we're looking at others (https://reactstrap.github.io/). To make a decision to stay on your project or go to another we need to understand the timing of the implementation of version 4.

I understand that you are doing this with your enthusiasm and thank you for this! But still it is important for us to understand how the project will develop in future

@jquense

This comment has been minimized.

Member

jquense commented Apr 3, 2018

I don't have a specific time in mind,but you can look at the projects tab to get a sense of the rate and progress towards v4 support

@makhnatkin

This comment has been minimized.

makhnatkin commented Apr 3, 2018

@jquense thx!

@taion taion referenced this pull request Apr 4, 2018

Closed

[Question] V4 release date #3104

@holmrenser

This comment has been minimized.

holmrenser commented Apr 24, 2018

https://react-bootstrap.github.io/ still refers to this PR

@rafaell-lycan

This comment has been minimized.

rafaell-lycan commented Jul 9, 2018

Currently I'm using the https://reactstrap.github.io/ and it's working just fine with the Bootstrap 4.

@doniyor2109

This comment has been minimized.

doniyor2109 commented Jul 17, 2018

Is there any news in this PR or we should use https://reactstrap.github.io/ ?

@jquense

This comment has been minimized.

Member

jquense commented Jul 17, 2018

@doniyor2109 please read the issue: #2752 (comment)

@SachaG

This comment has been minimized.

SachaG commented Jul 27, 2018

Is there a guide on how to start using the next version even if it's incomplete? It might help drive people to contribute if they can already start using it?

@holmrenser

This comment has been minimized.

holmrenser commented Jul 27, 2018

@pedrofurtado

This comment has been minimized.

pedrofurtado commented Jul 30, 2018

@jquense Any news? As @holmrenser mentioned, https://react-bootstrap.github.io/ still refers to this PR.

@jquense

This comment has been minimized.

Member

jquense commented Jul 30, 2018

@react-bootstrap react-bootstrap locked as resolved and limited conversation to collaborators Jul 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.