Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default Nav components to non ul/li #3339

Merged
merged 3 commits into from Nov 7, 2018
Merged

feat: change default Nav components to non ul/li #3339

merged 3 commits into from Nov 7, 2018

Conversation

@jquense
Copy link
Member

jquense commented Oct 19, 2018

BREAKING CHANGE: components no longer default to a list

@jquense jquense changed the title feat: change default Nav components to none ul/li feat: change default Nav components to non ul/li Oct 19, 2018
Copy link
Member

taion left a comment

this doesn't screw up any of the layout stuff? ok

@taion

This comment has been minimized.

Copy link
Member

taion commented Oct 19, 2018

btw, with nesting nav in nav with <Navbar> and <Nav>, will anything bad happen?

@jquense

This comment has been minimized.

Copy link
Member Author

jquense commented Oct 19, 2018

o shoot does navbar render a nav? this should probably be a plain div then...

@taion

This comment has been minimized.

Copy link
Member

taion commented Oct 19, 2018

by default yeah

as: 'nav',

jquense added 2 commits Oct 19, 2018
BREAKING CHANGE: components no longer default to a list
@jquense jquense force-pushed the nav-default branch from c6f79ed to 56a1a5d Nov 1, 2018
@jquense

This comment has been minimized.

Copy link
Member Author

jquense commented Nov 1, 2018

we need to figure out why FF keeps failing in tests...

@jquense

This comment has been minimized.

Copy link
Member Author

jquense commented Nov 7, 2018

also fixes #3360

@taion
taion approved these changes Nov 7, 2018
@jquense jquense merged commit 59127e6 into master Nov 7, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@jquense jquense deleted the nav-default branch Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.