Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix up accordions a bit #3615

Merged
merged 1 commit into from Apr 10, 2019
Merged

fix: Fix up accordions a bit #3615

merged 1 commit into from Apr 10, 2019

Conversation

@taion
Copy link
Member

taion commented Apr 9, 2019

Fixes #3614

@bpas247 My bad, some confusion on my end in how our APIs worked

);
};
return (
<Collapse ref={ref} in={contextEventKey === eventKey} {...props}>

This comment has been minimized.

Copy link
@taion

taion Apr 9, 2019

Author Member

i forgot that <Collapse> didn't render a <div> on its own

onClick={() => {
onSelect(eventKey);
if (onClick) onClick(eventKey);
onClick={e => {

This comment has been minimized.

Copy link
@taion

taion Apr 9, 2019

Author Member

this is how the other onClick and onSelect things work

onClick={key => console.log(`I've been clicked by : ${key}`)}
eventKey="0"
>
<Accordion.Toggle as={Button} variant="link" eventKey="0">

This comment has been minimized.

Copy link
@taion

taion Apr 9, 2019

Author Member

so, the default of <button> here is a little weird in retrospect. the TWBS example upstream uses <Button variant="link">, as this makes things work, but i wonder if we should just use <SafeAnchor> instead

@bpas247
bpas247 approved these changes Apr 9, 2019
Copy link
Member

bpas247 left a comment

LGTM 👍

@taion taion merged commit 511e566 into master Apr 10, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@taion taion deleted the fix-accordion branch Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.