Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignRight type #3828

Merged
merged 2 commits into from May 23, 2019

Conversation

@schaeferthomas
Copy link
Contributor

schaeferthomas commented May 23, 2019

Change from alignRight?: true to alignRight?: boolean

PropTypes of DropdownMenu state that alignRight is a boolean and can be undefined (alignRight: PropTypes.bool) but the TypeScript definitions don't allow false.

schaeferthomas and others added 2 commits May 23, 2019
Change from alignRight: true to alignRight?: boolean
@jquense jquense merged commit 1dd21eb into react-bootstrap:master May 23, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@schaeferthomas schaeferthomas deleted the schaeferthomas:patch-1 branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.