Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix coverage #3885

Merged
merged 1 commit into from Jun 10, 2019
Merged

test: Fix coverage #3885

merged 1 commit into from Jun 10, 2019

Conversation

taion
Copy link
Member

@taion taion commented Jun 10, 2019

Fixes #3864

@taion taion requested review from jquense and mxschmitt June 10, 2019 15:00
@taion
Copy link
Member Author

taion commented Jun 10, 2019

@mxschmitt So Codecov sees it now: https://codecov.io/gh/react-bootstrap/react-bootstrap/commit/cd3de10417cb27ebadeefc266f5b30112e73a31b

But there's no check?

@taion
Copy link
Member Author

taion commented Jun 10, 2019

Might be from a missing base report.

@mxschmitt
Copy link
Member

@taion yep I think base report is missing. Very cool! :)

@taion taion merged commit 0796588 into master Jun 10, 2019
@taion taion deleted the fix-cov branch June 10, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Coverage won't reported to codecov
3 participants
@taion @mxschmitt @jquense