Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add types for Popover sub-components #4093

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@chamini2
Copy link
Contributor

chamini2 commented Jul 18, 2019

I need this to add popovers to my app

@taion taion changed the title add Popover.Title, PopoverTitle, Popover.Content and PopoverContent fix: Add types for Popover sub-components Jul 19, 2019
@taion
taion approved these changes Jul 19, 2019
@bpas247 bpas247 merged commit 1465811 into react-bootstrap:master Jul 21, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 93.61% (-0.16%) compared to 5ee5e56
Details
codecov/patch Coverage not affected when comparing 5ee5e56...5c0895d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
bpas247 added a commit that referenced this pull request Jul 21, 2019
This was probably missed in #4093 before merge.
@chamini2 chamini2 deleted the chamini2:popover-types branch Jul 22, 2019
mxschmitt added a commit that referenced this pull request Jul 23, 2019
This was probably missed in #4093 before merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.