Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): directly show backdrop if no animation (fix: #4190) #4192

Merged
merged 4 commits into from Aug 6, 2019

Conversation

@mxschmitt
Copy link
Member

mxschmitt commented Aug 6, 2019

src/Modal.js Outdated Show resolved Hide resolved
www/src/pages/components/modal.js Outdated Show resolved Hide resolved
mxschmitt and others added 2 commits Aug 6, 2019
Co-Authored-By: Jason Quense <monastic.panic@gmail.com>
@taion
taion approved these changes Aug 6, 2019
@mxschmitt mxschmitt requested a review from jquense Aug 6, 2019
@jquense
jquense approved these changes Aug 6, 2019
@mxschmitt mxschmitt merged commit 0d02bf6 into master Aug 6, 2019
5 checks passed
5 checks passed
codecov/patch 100% of diff hit (target 95.11%)
Details
codecov/project Absolute coverage decreased by -0.15% but relative coverage increased by +4.88% compared to b36d261
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@mxschmitt mxschmitt deleted the bugfix/4190 branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.