Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Toast component #4246

Merged
merged 2 commits into from Aug 14, 2019
Merged

fix(types): Toast component #4246

merged 2 commits into from Aug 14, 2019

Conversation

@mxschmitt
Copy link
Member

mxschmitt commented Aug 13, 2019

I don't know how to fix this, but that's at least the test for it.
Would be cool if someone could help me :)

@taion

This comment has been minimized.

Copy link
Member

taion commented Aug 13, 2019

show and transition aren't marked optional in

show: boolean;
transition: boolean | React.ElementType;

Is that intentional? That's the error you're seeing.

@mxschmitt

This comment has been minimized.

Copy link
Member Author

mxschmitt commented Aug 13, 2019

show and transition aren't marked optional in

show: boolean;
transition: boolean | React.ElementType;

Is that intentional? That's the error you're seeing.

I don't think so, because we provide defaultProps there. So true for show and Fade for transition. I've adjusted it.

And thanks @taion!

@taion
taion approved these changes Aug 13, 2019
@mxschmitt mxschmitt added the types label Aug 13, 2019
@mxschmitt mxschmitt merged commit c30e131 into master Aug 14, 2019
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing b77d686...c9869e7
Details
codecov/project 94.98% remains the same compared to b77d686
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@mxschmitt mxschmitt deleted the bugfix/Toast branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.