diff --git a/src/ModalManager.js b/src/ModalManager.js index ae0fa6d9..59b53d09 100644 --- a/src/ModalManager.js +++ b/src/ModalManager.js @@ -75,7 +75,7 @@ class ModalManager { this.modals.push(modal); if (this.hideSiblingNodes) { - hideSiblings(container, modal.mountNode); + hideSiblings(container, modal.modalNode); } if (containerIdx !== -1) { @@ -131,14 +131,14 @@ class ModalManager { } if (this.hideSiblingNodes) { - showSiblings(container, modal.mountNode); + showSiblings(container, modal.modalNode); } this.containers.splice(containerIdx, 1); this.data.splice(containerIdx, 1); } else if (this.hideSiblingNodes) { //otherwise make sure the next top modal is visible to a SR - ariaHidden(false, data.modals[data.modals.length - 1].mountNode); + ariaHidden(false, data.modals[data.modals.length - 1].modalNode); } } diff --git a/test/ModalManagerSpec.js b/test/ModalManagerSpec.js index 09d47a2c..75a05425 100644 --- a/test/ModalManagerSpec.js +++ b/test/ModalManagerSpec.js @@ -110,6 +110,17 @@ describe('ModalManager', ()=> { expect(app.getAttribute('aria-hidden')).to.equal('true'); }); + it('should not add aria-hidden to modal', ()=>{ + let modal = new Modal({}); + let mount = document.createElement('div'); + + modal.modalNode = mount; + container.appendChild(mount); + manager.add(modal, container); + + expect(mount.getAttribute('aria-hidden')).to.equal(null); + }); + it('should add aria-hidden to previous modals', ()=>{ let modalA = new Modal({}); let mount = document.createElement('div'); @@ -129,7 +140,7 @@ describe('ModalManager', ()=> { let modalB = new Modal({}); let mount = document.createElement('div'); - modalA.mountNode = mount; + modalA.modalNode = mount; container.appendChild(mount); manager.add(modalA, container);