Skip to content
This repository was archived by the owner on Nov 4, 2025. It is now read-only.

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 8, 2019

Use latest react version.

@zombieJ zombieJ requested a review from afc163 October 8, 2019 12:39
@vercel
Copy link

vercel bot commented Oct 8, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://align-git-next.react-component.now.sh

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2019

This pull request introduces 1 alert and fixes 1 when merging 6d801cb into 8418bba - view on LGTM.com

new alerts:

  • 1 for Useless conditional

fixed alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2019

This pull request fixes 1 alert when merging 1728254 into 8418bba - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2019

This pull request fixes 1 alert when merging 39131a7 into 8418bba - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8418bba). Click here to learn what that means.
The diff coverage is 91.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage          ?   91.34%           
=========================================
  Files             ?        3           
  Lines             ?      104           
  Branches          ?       24           
=========================================
  Hits              ?       95           
  Misses            ?        9           
  Partials          ?        0
Impacted Files Coverage Δ
src/hooks/useBuffer.tsx 100% <100%> (ø)
src/Align.tsx 100% <100%> (ø)
src/util.ts 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8418bba...39131a7. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Oct 8, 2019

LGTM

@zombieJ zombieJ merged commit 07daf9e into master Oct 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the next branch October 8, 2019 14:55
...base,
rules: {
...base.rules,
'react/no-find-dom-node': 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是不是不用关。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

它纯粹是根据名字来的,会把 rc-util 的 findDOMNode 当成 react 的

...base.rules,
'react/no-find-dom-node': 0,
'jsx-a11y/label-has-associated-control': 0,
'jsx-a11y/label-has-for': 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个也没必要关。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example 里识别的有问题,label 嵌套了 input 它认不出来。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants