-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://align-git-next.react-component.now.sh |
|
This pull request introduces 1 alert and fixes 1 when merging 6d801cb into 8418bba - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging 1728254 into 8418bba - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 39131a7 into 8418bba - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=========================================
Coverage ? 91.34%
=========================================
Files ? 3
Lines ? 104
Branches ? 24
=========================================
Hits ? 95
Misses ? 9
Partials ? 0
Continue to review full report at Codecov.
|
|
LGTM |
| ...base, | ||
| rules: { | ||
| ...base.rules, | ||
| 'react/no-find-dom-node': 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是不是不用关。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
它纯粹是根据名字来的,会把 rc-util 的 findDOMNode 当成 react 的
| ...base.rules, | ||
| 'react/no-find-dom-node': 0, | ||
| 'jsx-a11y/label-has-associated-control': 0, | ||
| 'jsx-a11y/label-has-for': 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个也没必要关。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example 里识别的有问题,label 嵌套了 input 它认不出来。
Use latest react version.