Skip to content
This repository was archived by the owner on Nov 4, 2025. It is now read-only.

Conversation

@shaodahong
Copy link
Member

@vercel
Copy link

vercel bot commented Nov 8, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/align/mfl5cjeuu
🌍 Preview: https://align-git-fix-source-width-changed.react-component.now.sh

@shaodahong shaodahong requested a review from zombieJ November 8, 2019 13:15
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #35 into master will increase coverage by 0.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   92.24%   92.68%   +0.44%     
==========================================
  Files           3        3              
  Lines         116      123       +7     
  Branches       26       27       +1     
==========================================
+ Hits          107      114       +7     
  Misses          9        9
Impacted Files Coverage Δ
src/Align.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc51002...60988e1. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Nov 11, 2019

看看能不能用 rc-resize-observer替换掉,这边其实也不真的关心尺寸。

@shaodahong
Copy link
Member Author

看看能不能用 rc-resize-observer替换掉,这边其实也不真的关心尺寸。

主要是用于 submenu 展开的时候需要触发 adjustX 或者 adjustX 这种,我现在用 monitorResize 改造了下,看看

@zombieJ
Copy link
Member

zombieJ commented Nov 12, 2019

看了下没问题,在 rc-cascader 里试试,如果 ok 我这边直接合了。

@shaodahong
Copy link
Member Author

link 过去可以了,合吧

@zombieJ zombieJ merged commit 6ecc42b into master Nov 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-source-width-changed branch November 12, 2019 02:39
@zombieJ
Copy link
Member

zombieJ commented Nov 12, 2019

+ rc-align@3.0.0-alpha.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants