Skip to content

chore: Add react and react-dom as peer dependencies and update snapshot #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2020
Merged

chore: Add react and react-dom as peer dependencies and update snapshot #110

merged 2 commits into from
Oct 30, 2020

Conversation

@yoyo837
Copy link
Member

@yoyo837 yoyo837 commented Oct 30, 2020 •
edited
Loading

close #108

@yoyo837 yoyo837 changed the title chore: update snapshot chore: Add react and react-dom as peer dependencies and update snapshot Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files           4        4           
  Lines         265      265           
  Branches       91       91           
=======================================
  Hits          246      246           
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b099d37...cda633e. Read the comment docs.

@yoyo837 yoyo837 merged commit d20ae24 into master Oct 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the snap branch October 30, 2020 10:45
@kerm1it
Copy link
Member

kerm1it commented Oct 30, 2020

有空把CI换一下，travis CI 太慢了。
react-component/notification#135

@yoyo837
Copy link
Member Author

yoyo837 commented Oct 30, 2020

照抄吗

@kerm1it
Copy link
Member

kerm1it commented Oct 30, 2020

是的，改 README 的徽章链接时注意仓库名就行。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoyo837 @kerm1it